-
Notifications
You must be signed in to change notification settings - Fork 449
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support {} for empty inlined record literals and types #5900
Conversation
@cknitt Could you let me know what branch this PR goes to? Both |
I would say both |
Got it! I'll make another PR that goes to |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great!
@cristianoc Is the support for the empty inlined record type also needed? If it is needed, then I think all we need to remove https://github.com/rescript-lang/rescript-compiler/blob/master/res_syntax/src/res_core.ml#L4657:L4664 type inlinedOptional3 = V0({}) // empty inlined record
let ir6 = V0({}) |
Can't imagine why one would want that. Do you think there's a possible use case? |
Neither do I. I just want to ask your idea if it is needed. |
Changelog entry should go to version 10.1.1 in both branches. |
Updated: eb3ff55 |
This PR fixes #5899