Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add communities to edit software #1220

Merged
merged 1 commit into from
Jun 10, 2024

Conversation

dmijatovic
Copy link
Contributor

@dmijatovic dmijatovic commented Jun 4, 2024

Add communities to edit software section

Closes #1215

Changes proposed in this pull request:

  • The software maintainer can request to join an community
  • If the communities module is not enabled in settings.json the communites option is hidden. Note! The menu option is simply hidden but the route is not completely disabled.
  • The communities module is not enabled by default
  • The communities can be still created by rsd administrators. The communities page is enabled in the admin section.

How to test:

  • make start to build and create test data
  • confirm that "Communities" menu option is not present in the header of the page
  • login as rsd-admin ((first user is always promoted to rsd-admin in dev), navigate to edit software section. Confirm that communities page is not shown.
  • navigate to admin section and confirm that communities page is present. Eg. rsd-admins can create communities while the module is not enabled/pages shown to users.
  • stop RSD using docker compose down
  • Add "communities" to rsd modules in frontend/public/data/settings.json
{
"host": {
    ...
    "modules":["software","projects","organisations","communities"]
  },
 ....
  • make start to build and create test. Note! When changing settings.json values in production it is not necessary to build. However make start is the simplest way to use in test instructions :-)
  • Login as rsd admin (first user is always promoted to rsd-admin in dev).
  • Navigate to edit software page (or create new software)
  • Confirm that communities page (see example below) is present.
  • Try to joint some communities. Initially the status shown will be "pending". Check the titles, info and descriptions on this page.
  • Navigate to one of the communities you want to join (you can use link directly from the communities list in edit software - click on the community name)
  • As rsd admin confirm that the software is in the list of "requests". You can accept or reject the request. Try accepting one an rejecting another request. Then navigate back to software and confirm that status is updated (note! you might need to reload edit software communities page)
  • On edit software - communities page try to "leave" communities (eg. delete community memberiship from software)

Example communities of edit software section

image

Example community request

image

PR Checklist:

  • Increase version numbers in docker-compose.yml
  • Link to a GitHub issue
  • Update documentation
  • Tests

@dmijatovic dmijatovic force-pushed the 1215-edit-software-com branch 2 times, most recently from 9cdd44b to 0881ec7 Compare June 6, 2024 11:49
test: fix broken test and extend with communties check
note: communties is disabled by default
Copy link

sonarcloud bot commented Jun 6, 2024

Quality Gate Passed Quality Gate passed for 'rsd-database'

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link

sonarcloud bot commented Jun 6, 2024

@dmijatovic dmijatovic marked this pull request as ready for review June 6, 2024 12:37
Copy link
Member

@jmaassen jmaassen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works as expected

@dmijatovic dmijatovic merged commit 061b4b9 into 616-communities Jun 10, 2024
6 checks passed
@dmijatovic dmijatovic mentioned this pull request Jun 10, 2024
4 tasks
dmijatovic added a commit that referenced this pull request Jun 10, 2024
test: fix broken test and extend with communties check
note: communties is disabled by default
@dmijatovic dmijatovic deleted the 1215-edit-software-com branch July 8, 2024 08:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants