Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Payment information does not get retracted properly #10

Open
sigpie opened this issue Mar 13, 2019 · 2 comments
Open

Payment information does not get retracted properly #10

sigpie opened this issue Mar 13, 2019 · 2 comments

Comments

@sigpie
Copy link
Contributor

sigpie commented Mar 13, 2019

If incorrect payment information is submitted to the bot, this can't be corrected without opening a new connection.

Example:

retract-bug

This generates the error output:

13.3.19 19:04:31.934 [taskScheduler-3] INFO  w.p.p.b.a.p.PreconditionUnmetAction - Precondition unmet
13.3.19 19:04:32.415 [taskScheduler-3] INFO  w.p.p.b.a.p.PreconditionUnmetAction - Payment not possible yet, missing necessary Values: 
Invoice: More than 1 values 

This might be due to the saved information not being deleted after a retraction.

@quasarchimaere
Copy link
Collaborator

not a bug shacl constraint validation go across the whole message chain, in order for this to work you "simply" have to retract the first payment detail message

@sigpie
Copy link
Contributor Author

sigpie commented Mar 15, 2019

In this case the issue is that this process isn't clear at all. The bot should either tell the user what to do or, if possible, even initiate the necessary steps.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants