Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(render): Substitute implementation of render with the one from renderAsync #1268

Open
wants to merge 19 commits into
base: canary
Choose a base branch
from
Open

feat(render): Substitute implementation of render with the one from renderAsync #1268

wants to merge 19 commits into from

Conversation

gabrielmfern
Copy link
Collaborator

@gabrielmfern gabrielmfern commented Jan 30, 2024 •
edited
Loading

This deprecates renderAsync and replaces the implementation of render with the implementation
from renderAsync. Along with this implementation change of render, I also added the unit tests from renderAsync to render.

Since many of our tests use the render utility, I had to change them all to make sure that the render's returned Promise is now treated correctly.

I believe this is the best course of action for a couple of reasons that I go in depth on #1144.

Issues that this can help fix

@vercel Vercel
Copy link

vercel bot commented Jan 30, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
react-email ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 4, 2024 4:01pm
react-email-demo ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 4, 2024 4:01pm

This was linked to issues Jan 30, 2024
Can only use @react-email/render and @react-email/components with serverComponentsExternalPackages on NextJS #977
Open
renderToReadableStream function throws an error in Next.js 14 #1029
Open
Render emails in Next JS client component throws at renderToStaticMarkup #1080
Open
@antoinerousseau
Copy link

does this mean the react-email preview page would support async components? (RSC)
that would be great!

@gabrielmfern
Copy link
Collaborator Author

@antoinerousseau That'd be pretty cool and I'll still experiment with that but no, not yet, mostly it would be possible to have something like react-query.

@edeuxk
Copy link

edeuxk commented Feb 5, 2024

Hello @gabrielmfern thank you for this amazing work.
Does your PR includes the ReadableByteStreamController with Safari ?

@gabrielmfern
Copy link
Collaborator Author

gabrielmfern commented Feb 5, 2024 •
edited
Loading

Does your PR includes the ReadableByteStreamController with Safari ?

@edeuxk
I don't think so. Could you link some resources? I've never heard of that

@gabrielmfern gabrielmfern changed the title feat(react-email): Substitute implementation of render with the one from renderAsync feat(render): Substitute implementation of render with the one from renderAsync Feb 16, 2024
@gabrielmfern gabrielmfern marked this pull request as draft March 5, 2024 14:23
@gabrielmfern gabrielmfern marked this pull request as ready for review March 5, 2024 15:18
@gabrielmfern gabrielmfern added Package: @react-email/render Breaking change An issue or pull request that propose a change that break existing code labels Mar 6, 2024
@gabrielmfern gabrielmfern force-pushed the feat/only-support-render-async branch from d136d37 to eeca866 Compare March 18, 2024 17:32
@gabrielmfern gabrielmfern requested review from vcapretz and removed request for bukinoshita April 3, 2024 14:22
endymion1818 and others added 4 commits April 3, 2024 11:49
@endymion1818 @bennyburrito
@benverspeak @gabrielmfern @bukinoshita
feat(head): iOS formatting meta tag as default (#1369)
6297e7b 
Co-authored-by: Benny Burrito <87976514+bennyburrito@users.noreply.github.com>
Co-authored-by: Ben Verspeak <ben.verspeak@yonderland.com>
Co-authored-by: Gabriel Miranda <gabrielmfern@outlook.com>
@hank619 @bukinoshita
fix(create-email): Tailwind imported from @react-email/tailwind which…
45c69f6 
… is not installed (#1387)

Co-authored-by: zhanghong <hong.zhang@axinan.com>
@renovate @bukinoshita
chore(deps): update dependency postcss to v8.4.38 (#1392)
a6f4809 
Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@nzben @bukinoshita
fix(tailwind): React.forwardRef components not working (#1335)
85a0771
@gabrielmfern gabrielmfern force-pushed the feat/only-support-render-async branch from 9cb4e7f to 8b8df81 Compare April 4, 2024 16:00
@RomainGueffier
Copy link

Does your PR includes the ReadableByteStreamController with Safari ?

@edeuxk I don't think so. Could you link some resources? I've never heard of that

Hi @gabrielmfern we mentioned it in this issue #1080 (comment)

@gabrielmfern gabrielmfern force-pushed the canary branch 3 times, most recently from 8a41d44 to a0a0c9a Compare July 1, 2024 13:49
@gabrielmfern gabrielmfern force-pushed the canary branch 3 times, most recently from e001f5e to f5cf05c Compare July 3, 2024 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcapretz vcapretz Awaiting requested review from vcapretz

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Breaking change An issue or pull request that propose a change that break existing code Package: @react-email/render
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@gabrielmfern @antoinerousseau @edeuxk @RomainGueffier @endymion1818 @hank619 @nzben