Skip to content
This repository has been archived by the owner on Jun 8, 2022. It is now read-only.

GRIM, SHADERS: Toggle light inside drawMesh. #1258

Merged
merged 3 commits into from Jul 14, 2016
Merged

GRIM, SHADERS: Toggle light inside drawMesh. #1258

merged 3 commits into from Jul 14, 2016

Conversation

vpelletier
Copy link
Member

Fixes appearance of roulettes in cn and beavers in dm (#1186).

@bgK
Copy link
Member

bgK commented Jul 9, 2016

👍

@vpelletier
GRIM, SHADERS: Toggle light inside drawMesh.
7108b8c 
Fixes appearance of roulettes in cn and beavers in dm (residualvm#1186).
@vpelletier
GRIM, SHADERS: Drop no-op calls in GfxOpenGLS::drawMesh.
c57691c 
disableLight/enableLight only set _lightsEnabled, and nothing reads it
between these two calls.
@vpelletier
GRIM, SHADERS: Reduce differences between GRIM and EMI shaders.
a53e364
@vpelletier
Copy link
Member Author

Reworked patch 1 to not enable lighting in shadow mode.
Added patch 2 to remove dead calls to *ableLight inside the loop in drawMesh.
Added patch 3 to reduce differences between GRIM and EMI actor vertex shaders. The main purpose here is to make obvious that lightsEnabled and shadow._active are not necessarily mutually exclusive (as far as shaders are concerned).

@aquadran
Copy link
Member

👍

@aquadran aquadran merged commit ca64a56 into residualvm:master Jul 14, 2016
@vpelletier vpelletier mentioned this pull request Nov 6, 2016
Closed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vpelletier @bgK @aquadran