perf: update values with one db query

(cherry picked from commit 6a91ffd)
resilient-tech · Aug 22, 2024 · eacec63 · eacec63
1 parent 7e139c3
commit eacec63
Showing 1 changed file with 5 additions and 6 deletions.
diff --git a/india_compliance/patches/v15/update_action_for_gst_inward_supply.py b/india_compliance/patches/v15/update_action_for_gst_inward_supply.py
@@ -2,11 +2,10 @@
 
 
 def execute():
-    docs = frappe.get_all(
+    # Discard the action "Accept Supplier Values"
+    frappe.db.set_value(
         "GST Inward Supply",
-        filters={"action": ["in", ["Accept My Values", "Accept Supplier Values"]]},
-        pluck="name",
+        {"action": ["in", ["Accept My Values", "Accept Supplier Values"]]},
+        "action",
+        "Accept",
     )
-
-    for doc in docs:
-        frappe.db.set_value("GST Inward Supply", doc, "action", "Accept")