Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: auto-reconcile purchases with GSTR2A #1437

Merged
merged 11 commits into from
Mar 18, 2024
Merged

Conversation

vorasmit
Copy link
Collaborator

@vorasmit vorasmit commented Dec 19, 2023

Feature Highlight

  • Auto Reconciliation Settings (in GST Settings)
  • Support Multi-GSTIN reconciliation in one go. This will help identify incorrect company GSTIN when mapping.
  • With this, added a feature to authenticate multiple GSTINs in one go for purchase reconciliation (for downloading 2A/2B).
  • Auto download and reconcile purchases periodically as per settings.

docs: resilient-tech/india-compliance-docs#32

vishakhdesai and others added 7 commits December 17, 2023 13:36
Co-authored-by: Smit Vora <smitvora203@gmail.com>
* fix: auto reconcile purchases

* fix: comments added

* fix: refactor gst settings ui

* fix: seperate cron jobs to download gstr2a and 2b and auto reconciliation

* fix: make a class for all the methods -AutoReconciliation

* refactor: sequence of functions, minor functional refactor, renames

---------

Co-authored-by: Smit Vora <smitvora203@gmail.com>
@vorasmit vorasmit changed the title fix: Refresh auth token in Purchase Reconciliation Tool (#1319) feat: auto-reconcile purchases with GSTR2A Mar 12, 2024
@vorasmit vorasmit marked this pull request as ready for review March 14, 2024 05:16
Copy link

codecov bot commented Mar 14, 2024

Codecov Report

Attention: Patch coverage is 28.08219% with 105 lines in your changes are missing coverage. Please review.

Project coverage is 64.19%. Comparing base (f749c62) to head (7f77f6c).
Report is 1 commits behind head on develop.

Files Patch % Lines
...econciliation_tool/purchase_reconciliation_tool.py 24.13% 66 Missing ⚠️
india_compliance/gst_india/utils/gstr/gstr.py 31.42% 24 Missing ⚠️
india_compliance/gst_india/api_classes/returns.py 14.28% 12 Missing ⚠️
...a/doctype/purchase_reconciliation_tool/__init__.py 71.42% 2 Missing ⚠️
india_compliance/gst_india/utils/gstr/__init__.py 66.66% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1437      +/-   ##
===========================================
+ Coverage    60.39%   64.19%   +3.80%     
===========================================
  Files          102      102              
  Lines         8155     8268     +113     
===========================================
+ Hits          4925     5308     +383     
+ Misses        3230     2960     -270     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vorasmit vorasmit merged commit e1bb1cc into develop Mar 18, 2024
13 of 15 checks passed
@vorasmit vorasmit deleted the auto-reconcile-purchases branch March 18, 2024 08:02
mergify bot pushed a commit that referenced this pull request Mar 18, 2024
* fix: Refresh auth token in Purchase Reconciliation Tool (#1319)

Co-authored-by: Smit Vora <smitvora203@gmail.com>

* fix: Reconcile Purchases for Multiple GSTIN (#1367)

* fix: auto refresh auth token

* fix: linters

* fix: Auto Reconcile Purchases (#1562)

* fix: auto reconcile purchases

* fix: comments added

* fix: refactor gst settings ui

* fix: seperate cron jobs to download gstr2a and 2b and auto reconciliation

* fix: make a class for all the methods -AutoReconciliation

* refactor: sequence of functions, minor functional refactor, renames

---------

Co-authored-by: Smit Vora <smitvora203@gmail.com>

* fix: linters, test case

* refactor: no need for auto purchase reco companies

* fix: default settings for auto reco tool

---------
Co-authored-by: Vishakh Desai <vishakhdesai@gmail.com>

(cherry picked from commit e1bb1cc)
mergify bot pushed a commit that referenced this pull request Mar 18, 2024
* fix: Refresh auth token in Purchase Reconciliation Tool (#1319)

Co-authored-by: Smit Vora <smitvora203@gmail.com>

* fix: Reconcile Purchases for Multiple GSTIN (#1367)

* fix: auto refresh auth token

* fix: linters

* fix: Auto Reconcile Purchases (#1562)

* fix: auto reconcile purchases

* fix: comments added

* fix: refactor gst settings ui

* fix: seperate cron jobs to download gstr2a and 2b and auto reconciliation

* fix: make a class for all the methods -AutoReconciliation

* refactor: sequence of functions, minor functional refactor, renames

---------

Co-authored-by: Smit Vora <smitvora203@gmail.com>

* fix: linters, test case

* refactor: no need for auto purchase reco companies

* fix: default settings for auto reco tool

---------
Co-authored-by: Vishakh Desai <vishakhdesai@gmail.com>

(cherry picked from commit e1bb1cc)
mergify bot added a commit that referenced this pull request Mar 18, 2024
…tfix/pr-1437

feat: auto-reconcile purchases with GSTR2A (backport #1437)
vorasmit added a commit that referenced this pull request Mar 19, 2024
…tfix/pr-1437

feat: auto-reconcile purchases with GSTR2A (backport #1437)
india-compliance-bot added a commit that referenced this pull request Mar 21, 2024
# [15.6.0](v15.5.7...v15.6.0) (2024-03-21)

### Bug Fixes

* add GST Details and allow cess non advol in Bill of Entry ([#1866](#1866)) ([33847ff](33847ff))
* added TDS on Purchasing in Tax Withholding Category ([#1869](#1869)) ([d7a69af](d7a69af))
* changes as per review ([b183b86](b183b86))
* conflict ([0a8d32b](0a8d32b))
* ignore mandatory when creating or updating tax witholding category ([a36f89a](a36f89a))
* include TDS regex in GSTIN regex ([b7bac89](b7bac89))
* **minor:** keeps gst accounts in GST Settings as non-mandatory ([#1905](#1905)) ([8c92493](8c92493))
* re-order/add/rename GSTR1 report headers (excel) ([#1684](#1684)) ([ff9bd2d](ff9bd2d))
* set gstin and gstCategory ([afd8192](afd8192))
* use text editor for gst breakup table instead of long text ([c24d489](c24d489))
* **ux:** suggest custom cancel message based on original document type ([927fa8a](927fa8a))

### Features

* auto-reconcile purchases with GSTR2A ([#1437](#1437)) ([8e06d9c](8e06d9c)), closes [#1319](#1319) [#1367](#1367) [#1562](#1562)
india-compliance-bot added a commit that referenced this pull request Mar 21, 2024
# [14.25.0](v14.24.7...v14.25.0) (2024-03-21)

### Bug Fixes

* add GST Details and allow cess non advol in Bill of Entry ([#1866](#1866)) ([f31eed8](f31eed8))
* added TDS on Purchasing in Tax Withholding Category ([#1869](#1869)) ([121b8e7](121b8e7))
* changes as per review ([95d9f7d](95d9f7d))
* conflicts ([562848f](562848f))
* ignore mandatory when creating or updating tax witholding category ([c155ff2](c155ff2))
* include TDS regex in GSTIN regex ([8772426](8772426))
* **minor:** keeps gst accounts in GST Settings as non-mandatory ([#1905](#1905)) ([e2bd000](e2bd000))
* re-order/add/rename GSTR1 report headers (excel) ([#1684](#1684)) ([b8aeb83](b8aeb83))
* set gstin and gstCategory ([36e79d1](36e79d1))
* use text editor for gst breakup table instead of long text ([2b2be36](2b2be36))
* **ux:** suggest custom cancel message based on original document type ([4c9be23](4c9be23))

### Features

* auto-reconcile purchases with GSTR2A ([#1437](#1437)) ([a26338a](a26338a)), closes [#1319](#1319) [#1367](#1367) [#1562](#1562)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants