fix: add GST Details and allow cess non advol in Bill of Entry #1866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Sanket322
commented
Mar 13, 2024
•
Sanket322
commented
- Create Fields
- Update GST Details
- Patch Data
- Test Cases
- allow cess non advol and tax on item quantity
- Test Cases for cess non advol
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #1866 +/- ##
===========================================
+ Coverage 64.24% 64.51% +0.26%
===========================================
Files 102 102
Lines 8274 8359 +85
===========================================
+ Hits 5316 5393 +77
- Misses 2958 2966 +8 ☔ View full report in Codecov by Sentry. |
ljain112
changed the title
vorasmit
reviewed
Mar 19, 2024
india_compliance/gst_india/doctype/bill_of_entry/bill_of_entry.py
Outdated
Show resolved
Hide resolved
vorasmit
reviewed
Mar 19, 2024
india_compliance/patches/v14/set_hsn_from_purchase_invoice_to_bill_of_entry.py
Outdated
Show resolved
Hide resolved
vorasmit
reviewed
Mar 19, 2024
vorasmit
reviewed
Mar 19, 2024
india_compliance/patches/v14/update_item_gst_details_and_gst_trearment_in_bill_of_entry.py
Outdated
Show resolved
Hide resolved
vorasmit
reviewed
Mar 19, 2024
india_compliance/gst_india/doctype/bill_of_entry_item/bill_of_entry_item.json
Show resolved
Hide resolved
ljain112
force-pushed
the
gst_details_in_boe
branch
from
21f165a
to
3c5074a
Compare
ljain112
changed the title
vorasmit
reviewed
Mar 20, 2024
vorasmit
reviewed
Mar 20, 2024
vorasmit
reviewed
Mar 20, 2024
india_compliance/gst_india/doctype/bill_of_entry/bill_of_entry.py
Outdated
Show resolved
Hide resolved
vorasmit
reviewed
Mar 20, 2024
india_compliance/gst_india/doctype/bill_of_entry/bill_of_entry.py
Outdated
Show resolved
Hide resolved
vorasmit
reviewed
Mar 20, 2024
ljain112
force-pushed
the
gst_details_in_boe
branch
5 times, most recently
from
74233af
to
fd2c0bb
Compare
ljain112
force-pushed
the
gst_details_in_boe
branch
from
fd2c0bb
to
2e27eec
Compare
…ance into gst_details_in_boe
ljain112
force-pushed
the
gst_details_in_boe
branch
from
62d71c5
to
f4dd1b0
Compare
mergify bot
pushed a commit
that referenced
this pull request
Mar 21, 2024
* fix: hsn-summary-of-inward-supply * fix: add gst details field in boe * fix: add function in hooks * fix: calcualte gst details in bill of entry * fix: removed additional lone * fix: add patches and tests * fix: patches * fix: remove patch * fix: tested patches and test_cases * fix: test_cases * fix: linters * fix: changes as per review * fix: set gst_treatment * fix: allow cess non advol in bill of entry * fix: changes to patch as per new fields * fix: changes as per review * fix: changes as per merge * chore: rename var, remove unavailable code --------- Co-authored-by: ljain112 <ljain112@gmail.com> Co-authored-by: Smit Vora <smitvora203@gmail.com> (cherry picked from commit 4af06b2) # Conflicts: # india_compliance/gst_india/overrides/transaction.py
6 tasks
mergify bot
pushed a commit
that referenced
this pull request
Mar 21, 2024
* fix: hsn-summary-of-inward-supply * fix: add gst details field in boe * fix: add function in hooks * fix: calcualte gst details in bill of entry * fix: removed additional lone * fix: add patches and tests * fix: patches * fix: remove patch * fix: tested patches and test_cases * fix: test_cases * fix: linters * fix: changes as per review * fix: set gst_treatment * fix: allow cess non advol in bill of entry * fix: changes to patch as per new fields * fix: changes as per review * fix: changes as per merge * chore: rename var, remove unavailable code --------- Co-authored-by: ljain112 <ljain112@gmail.com> Co-authored-by: Smit Vora <smitvora203@gmail.com> (cherry picked from commit 4af06b2) # Conflicts: # india_compliance/gst_india/overrides/transaction.py
6 tasks
vorasmit
added a commit
that referenced
this pull request
Mar 21, 2024
…tfix/pr-1866 fix: add GST Details and allow cess non advol in Bill of Entry (backport #1866)
vorasmit
added a commit
that referenced
this pull request
Mar 21, 2024
…tfix/pr-1866 fix: add GST Details and allow cess non advol in Bill of Entry (backport #1866)
india-compliance-bot
added a commit
that referenced
this pull request
Mar 21, 2024
# [15.6.0](v15.5.7...v15.6.0) (2024-03-21) ### Bug Fixes * add GST Details and allow cess non advol in Bill of Entry ([#1866](#1866)) ([33847ff](33847ff)) * added TDS on Purchasing in Tax Withholding Category ([#1869](#1869)) ([d7a69af](d7a69af)) * changes as per review ([b183b86](b183b86)) * conflict ([0a8d32b](0a8d32b)) * ignore mandatory when creating or updating tax witholding category ([a36f89a](a36f89a)) * include TDS regex in GSTIN regex ([b7bac89](b7bac89)) * **minor:** keeps gst accounts in GST Settings as non-mandatory ([#1905](#1905)) ([8c92493](8c92493)) * re-order/add/rename GSTR1 report headers (excel) ([#1684](#1684)) ([ff9bd2d](ff9bd2d)) * set gstin and gstCategory ([afd8192](afd8192)) * use text editor for gst breakup table instead of long text ([c24d489](c24d489)) * **ux:** suggest custom cancel message based on original document type ([927fa8a](927fa8a)) ### Features * auto-reconcile purchases with GSTR2A ([#1437](#1437)) ([8e06d9c](8e06d9c)), closes [#1319](#1319) [#1367](#1367) [#1562](#1562)
india-compliance-bot
added a commit
that referenced
this pull request
Mar 21, 2024
# [14.25.0](v14.24.7...v14.25.0) (2024-03-21) ### Bug Fixes * add GST Details and allow cess non advol in Bill of Entry ([#1866](#1866)) ([f31eed8](f31eed8)) * added TDS on Purchasing in Tax Withholding Category ([#1869](#1869)) ([121b8e7](121b8e7)) * changes as per review ([95d9f7d](95d9f7d)) * conflicts ([562848f](562848f)) * ignore mandatory when creating or updating tax witholding category ([c155ff2](c155ff2)) * include TDS regex in GSTIN regex ([8772426](8772426)) * **minor:** keeps gst accounts in GST Settings as non-mandatory ([#1905](#1905)) ([e2bd000](e2bd000)) * re-order/add/rename GSTR1 report headers (excel) ([#1684](#1684)) ([b8aeb83](b8aeb83)) * set gstin and gstCategory ([36e79d1](36e79d1)) * use text editor for gst breakup table instead of long text ([2b2be36](2b2be36)) * **ux:** suggest custom cancel message based on original document type ([4c9be23](4c9be23)) ### Features * auto-reconcile purchases with GSTR2A ([#1437](#1437)) ([a26338a](a26338a)), closes [#1319](#1319) [#1367](#1367) [#1562](#1562)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.