feat: section to report e-commerce sale through GSTR-1 #2125
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ljain112
reviewed
May 16, 2024
ljain112
reviewed
May 17, 2024
ljain112
reviewed
May 17, 2024
ljain112
reviewed
May 17, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## develop #2125 +/- ##
===========================================
- Coverage 61.40% 61.27% -0.14%
===========================================
Files 111 111
Lines 10685 10731 +46
===========================================
+ Hits 6561 6575 +14
- Misses 4124 4156 +32 ☔ View full report in Codecov by Sentry. |
priyanshshah2442
changed the title
ljain112
reviewed
May 20, 2024
ljain112
reviewed
May 20, 2024
ljain112
reviewed
May 21, 2024
india_compliance/patches/post_install/set_default_gst_settings.py
Outdated
Show resolved
Hide resolved
ljain112
reviewed
May 21, 2024
ljain112
reviewed
May 23, 2024
ljain112
reviewed
May 23, 2024
vorasmit
reviewed
May 23, 2024
…in GST compliance modules
ljain112
requested changes
May 24, 2024
vorasmit
changed the title
vorasmit
reviewed
May 25, 2024
vorasmit
previously approved these changes
Jun 13, 2024
vorasmit
approved these changes
Jun 13, 2024
vorasmit
added a commit
that referenced
this pull request
Jun 22, 2024
* fix: custom fields and validations for section 14 * fix: failing linters * fix: failing linter in js file * fix: update patch numbering * fix: minor changes ton validations * fix: supply_liable field to virtual field and remove all backend validations * fix: depends on for supply_liable_to field * fix: added section-14 in gstr-1 report * fix: download json and excel for section-14 * fix: failing linters * fix: as per review * fix: as per review * fix: modified query for section_14 data * fix: as per review * fix: changes as per review * fix: gstr-1 columns * fix: re-write section-14 query * fix: query for section-14 * fix: escape account name for query * refactor: field names and functions related to ecommerce supply type in GST compliance modules * fix: formatting fix * chore: better label * refactor: section-14 query * chore: rename func, comments * fix: supecommerce categories --------- Co-authored-by: priyanshshah2442 <priyanshshah2442@gmail.com> Co-authored-by: ljain112 <ljain112@gmail.com>
mergify bot
pushed a commit
that referenced
this pull request
Jun 22, 2024
* fix: custom fields and validations for section 14 * fix: failing linters * fix: failing linter in js file * fix: update patch numbering * fix: minor changes ton validations * fix: supply_liable field to virtual field and remove all backend validations * fix: depends on for supply_liable_to field * fix: added section-14 in gstr-1 report * fix: download json and excel for section-14 * fix: failing linters * fix: as per review * fix: as per review * fix: modified query for section_14 data * fix: as per review * fix: changes as per review * fix: gstr-1 columns * fix: re-write section-14 query * fix: query for section-14 * fix: escape account name for query * refactor: field names and functions related to ecommerce supply type in GST compliance modules * fix: formatting fix * chore: better label * refactor: section-14 query * chore: rename func, comments * fix: supecommerce categories --------- Co-authored-by: priyanshshah2442 <priyanshshah2442@gmail.com> Co-authored-by: ljain112 <ljain112@gmail.com> (cherry picked from commit 7bd5582) # Conflicts: # india_compliance/gst_india/overrides/transaction.py
india-compliance-bot
added a commit
that referenced
this pull request
Jun 24, 2024
# [14.28.0](v14.27.1...v14.28.0) (2024-06-24) ### Bug Fixes * add gst_tax_type field (backport [#2241](#2241)) ([2052a98](2052a98)) * allow address in india with overseas category for high sea sales ([d11b58d](d11b58d)) * changes as per reivew ([7098890](7098890)) * conflicts ([32dc09d](32dc09d)) * correct tab-name for v14 ([7a953dc](7a953dc)) * DoesNotExistError while processing return info ([6b794ad](6b794ad)) * don't export zero values for gstr-1 beta ([093684a](093684a)) * don't get gstin list if company is not available ([6692615](6692615)) * don't try downloading data if there are no return periods ([#2264](#2264)) ([fca60d2](fca60d2)) * **e-waybill:** conditional checks for purchase receipt ([edaff5c](edaff5c)) * failing test case fixed ([ef43aad](ef43aad)) * get correct tax amount for 3b ([57b1815](57b1815)) * get gstins if param party is available ([b42b21c](b42b21c)) * gst-transporter-id refactor ([a7f7e68](a7f7e68)) * **ineligible itc:** update GL's with valuation hook, refactor ([#2206](#2206)) ([c1606f7](c1606f7)), closes [#2193](#2193) * **reco-tool:** support date to last month for filtered mismatches ([b94cd96](b94cd96)) * show message for missing creds while generating gstr-1 ([8d241c6](8d241c6)) * show tax rate column only where required for GSTR-1 Beta ([a7a0855](a7a0855)) * specify parenttype for purchase taxes ([a50c03d](a50c03d)) * update taxable values for non gst items ([4a6c04c](4a6c04c)) * use correct field name for auth token auto refresh ([#2272](#2272)) ([e75b946](e75b946)) * use validate_gstin_check_digit instead of validate_gstin in validate_gst_transporter_id ([bedde72](bedde72)) * **ux:** show missing creds message only where relevant ([dc9fe2c](dc9fe2c)) * wait for otp authentication, link instead of button for ux ([b3bf213](b3bf213)) ### Features * support ecommerce sale from GSTR-1 (backport: [#2125](#2125)) ([#2281](#2281)) ([6b2b667](6b2b667))
india-compliance-bot
added a commit
that referenced
this pull request
Jun 24, 2024
# [15.9.0](v15.8.1...v15.9.0) (2024-06-24) ### Bug Fixes * add gst_tax_type field (backport [#2241](#2241)) ([cf1a43e](cf1a43e)) * allow address in india with overseas category for high sea sales ([3f2b7a5](3f2b7a5)) * better print format for `gst tax invoice` ([#2106](#2106)) ([209afe5](209afe5)) * changes as per reivew ([89e3b90](89e3b90)) * DoesNotExistError while processing return info ([d8a3e62](d8a3e62)) * don't export zero values for gstr-1 beta ([299ec40](299ec40)) * don't get gstin list if company is not available ([d83b46d](d83b46d)) * don't try downloading data if there are no return periods ([#2264](#2264)) ([ab6ff68](ab6ff68)) * **e-waybill:** conditional checks for purchase receipt ([2139585](2139585)) * enhance gst invoice format ([96ea718](96ea718)) * failing test case fixed ([74c575a](74c575a)) * generate correct web template for upi qr code ([062fea2](062fea2)) * get correct tax amount for 3b ([78ee46b](78ee46b)) * get gstins if param party is available ([40ba3dd](40ba3dd)) * gst-transporter-id refactor ([1f6870d](1f6870d)) * **ineligible itc:** update GL's with valuation hook, refactor ([#2206](#2206)) ([175b51a](175b51a)), closes [#2193](#2193) * parse param correctly in py ([b92b0bd](b92b0bd)) * **reco-tool:** support date to last month for filtered mismatches ([2a5780b](2a5780b)) * set default print format for Sales Invoice ([db1758c](db1758c)) * show message for missing creds while generating gstr-1 ([16b8f29](16b8f29)) * show tax rate column only where required for GSTR-1 Beta ([c951c01](c951c01)) * specify parenttype for purchase taxes ([3e86d56](3e86d56)) * update taxable values for non gst items ([9573130](9573130)) * use correct field name for auth token auto refresh ([#2272](#2272)) ([5fea9bd](5fea9bd)) * use validate_gstin_check_digit instead of validate_gstin in validate_gst_transporter_id ([301b901](301b901)) * **ux:** show missing creds message only where relevant ([4c13a38](4c13a38)) * wait for otp authentication, link instead of button for ux ([0fd1da7](0fd1da7)) ### Features * support ecommerce sale from GSTR-1 (backport: [#2125](#2125)) ([#2281](#2281)) ([7bd5582](7bd5582))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
docs: resilient-tech/india-compliance-docs#39