versionist support: add config and changelog file #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imrehg
force-pushed
the
versionbot
branch
2 times, most recently
from
9317884
to
15bce0f
Compare
|
@hedss when this PR will look good, can you enable VersionBot on this repo? (and then this could be the first PR merged by VersionBot itself, do I get that right?) |
Change-type: patch
ghost
merged commit 
ghost
removed
the
lurch
reviewed
Jul 6, 2017
| ' - {{capitalize this.subject}} [{{this.author}}]', | ||
| '{{else}}', | ||
| '* {{capitalize this.subject}}', | ||
| '{{/if}}', |
There was a problem hiding this comment.
I've just noticed that there's an inconsistency here - the 'if' part does - {{capitalize this.subject}} but the 'else' part does * {{capitalize this.subject}}.
And compare it to https://github.com/resin-io/versionist/blob/master/versionist.conf.js which uses just * and not -.
lurch
reviewed
Jul 6, 2017
| module.exports = { | ||
| // This setup allows the editing and parsing of footer tags to get version and type information, | ||
| // as well as ensuring tags of the type 'v<major>.<minor>.<patch>' are used. | ||
| // It increments in a semver compatible fashion and does not do ano NPM package info update (N/A). |
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Second part of #7 adding versionist support so VersionBot will know what to do, when enabled in this repo