Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setting to turn off rounded corners when lone application #11

Closed
vidarrio opened this issue Mar 1, 2020 · 5 comments
Closed

Setting to turn off rounded corners when lone application #11

vidarrio opened this issue Mar 1, 2020 · 5 comments

Comments

@vidarrio
Copy link

vidarrio commented Mar 1, 2020

Just like smart_gaps turns off gaps when there's a single application, have a setting that does the same but for rounded corners. Currently it looks pretty ugly with smart_gaps on.

@resloved
Copy link
Owner

resloved commented Mar 1, 2020

When smart_gaps is enabled and there is only one window it won't round the window as of fa1cc45

Close this issue if it's working as intended

@vidarrio vidarrio closed this as completed Mar 1, 2020
@vidarrio
Copy link
Author

vidarrio commented Mar 1, 2020

Works great thanks, a minor thing is that maybe it shouldn't disable rounded corners if there are only floating windows, alternatively if a window is floating, but it doesn't matter much.

@resloved
Copy link
Owner

resloved commented Mar 2, 2020

Hm, that makes sense to me. I just used the same logic that's used when determining if gaps should be removed. Now that I think of it removing the gaps wouldn't affect floating windows so they're never considered.

I'll see if it would be a simple fix.

@resloved
Copy link
Owner

resloved commented Mar 2, 2020

Floating windows will still be rounded when smart_gaps is on and there is less then two (1 or 0) non-floating windows as of f3fffba

I've never used smart_gaps before this, but I think this is the behavior that should be expected.

@vidarrio
Copy link
Author

vidarrio commented Mar 2, 2020

Thanks a lot, works perfectly!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants