Required parameters evaluating as optional

[ramsey]

I created a route that looks like this:

/accounts/*/catalogs/*

According to the documentation, that first asterisk is not an optional parameter. However, requests to /accounts/catalogs is matching on that. Shouldn't it be giving me a 404 or something?

Reproduction script:

<?php

include '../vendor/autoload.php';

$r3 = new \Respect\Rest\Router();

$r3->get('/accounts/*/catalogs/*', function($accountId, $catalogId = null) {
    echo "Account ID: {$accountId}, Catalog ID: {$catalogId}";
});

Request:

GET /accounts/catalogs HTTP/1.1
Host: localhost:8181
Content-Type: application/x-www-form-urlencoded; charset=utf-8
Accept-Encoding: identity, deflate, compress, gzip
Accept: */*
User-Agent: HTTPie/0.1.7-dev

Response:

HTTP/1.1 200 OK
Date: Thu, 10 May 2012 17:39:41 GMT
Server: Apache/2.2.20 (Ubuntu)
X-Powered-By: PHP/5.4.0-3~oneiric+4
Vary: Accept-Encoding
Content-Encoding: gzip
Content-Length: 42
Content-Type: text/html

Account ID: , Catalog ID: 

[alganet]

Wow, it seems to be a bug. We had past issues with optional parameters, seems like they're back.

I'm assigning me and @augustohp to fix this. Matches by path are done by regular expressions on AbstractRoute, we'll review that logic.

[alganet]

@ramsey this should be working properly now! Thanks to this issue, we also simplified our pattern matching and possibly improved performance a lot. Thank you!