Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Submission length #983

Merged

Conversation

lmcnulty
Copy link
Collaborator

@lmcnulty lmcnulty commented Aug 19, 2022

Resolves #846. Makes the field for the report text show errors the same way as the other fields.

image

@netlify
Copy link

netlify bot commented Aug 19, 2022

Deploy Preview for staging-aiid ready!

Name Link
🔨 Latest commit 97f4cda
🔍 Latest deploy log https://app.netlify.com/sites/staging-aiid/deploys/630e553fc7be2c0009189aef
😎 Deploy Preview https://deploy-preview-983--staging-aiid.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@lmcnulty lmcnulty added the PR: Needs Review This needs someone to review it label Aug 22, 2022
@cesarvarela
Copy link
Collaborator

A couple questions:

  • Why are not the error messages being set through yup?
  • Why not use the feedback class from react-bootstrap?

@lmcnulty
Copy link
Collaborator Author

There was no good reason, I just didn't that those options existed. Changed.

@cesarvarela
Copy link
Collaborator

Please merge staging now that deploy finishes 🥳

@cesarvarela cesarvarela added PR: Work Needed Work is needed before it is reviewed/merged and removed PR: Needs Review This needs someone to review it labels Aug 30, 2022
@cesarvarela cesarvarela merged commit 11b9f64 into responsible-ai-collaborative:staging Aug 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
PR: Work Needed Work is needed before it is reviewed/merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants