Added OSGi support #1063
Merged
Added OSGi support #1063
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks a lot, excellent! |
|
You're welcome. Any plans for a 3.1.2 release at the moment? |
|
No plans yet, sorry!
…On Sun, Sep 9, 2018 at 1:15 PM ponziani ***@***.***> wrote:
You're welcome.
Any plans for a 3.1.2 release at the moment?
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#1063 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AALalaLXZIZDZ3ybTHyYvUY00Xw1q8jyks5uZPhMgaJpZM4Wf_Wk>
.
|
|
@ponziani I'm trying to release REST Assured now but I have trouble getting the OSGi tests working with Java 11. I get this error when I run from Maven (it works from Intellij): Do you know how to solve this? |
|
Managed to work-around it by adding: but no I get other exceptions: which looks like a problem with Apache Felix? |
|
Hi Johan, Were you able to fix it for 3.2.0? I can try myself during the weekend if needed .. |
|
@ponziani I couldn't get it working with Java 11, but it works fine with Java 8. So I changed the travis integration to only include the osgi tests when using Java 8. So I'm not sure if it's a Java 11 issue or if it's just an issue with the tests. Would be great if you could check it out and provide some feedback. |
|
Hi Johan,
|
|
Thanks for pointing out the version mismatch, I guess that's because I need to include it when I make the release. |
|
I guess you could choose for the module to be part of the build by default, which makes you cannot forgot about it, but you need to exclude it manually when using java11. |
|
Yeah that makes sense
…On Sat, Oct 27, 2018 at 9:56 AM Steven Huypens ***@***.***> wrote:
I guess you could choose for the module to be part of the build by
default, which makes you cannot forgot about it, but you need to exclude it
manually when using java11.
—
You are receiving this because you modified the open/close state.
Reply to this email directly, view it on GitHub
<#1063 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AALalYF-UKKkrQf4JouCUNKJNuWpSEtJks5upC3qgaJpZM4Wf_Wk>
.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've OSGi-ed the 4 main modules of Rest Assured and added some integration tests to check the correct OSGi behaviour (using the techniques you already know form awaitility).
This makes https://github.com/ops4j/org.ops4j.pax.tipi/tree/master/rest-assured-3.0.2 obsolete. I've tried using the new OSGi-ed version in a project of my own and the tests were succesful.
Please have a look ..