Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug in GUI - sctpExtraHostAddress list for SCTP server is not set as empty after empty String #37

Closed
vetss opened this issue Feb 15, 2016 · 2 comments
Assignees
Labels
Milestone

Comments

@vetss
Copy link
Contributor

vetss commented Feb 15, 2016

If we are creating via GUI a new SCTP server if we leave "Extra Host Address" field empty sctpExtraHostAddress then extraHostAddresses will created with a single empty memebr, but must be empty.

To solve it we need to check in SctpManagementJmx.addSctpServer() method - check if the String extraHostAddresses value is null OR EMPTY and in both cases create an empty array.

We need to update both branches - master and netty-2 !!!

@vetss vetss added the bug label Feb 15, 2016
@vetss vetss self-assigned this Feb 15, 2016
@nhanth87
Copy link
Contributor

Hi Sergey,
this function also need to change:
public Association addSctpAssociation(String hostAddress, int hostPort, String peerAddress, int peerPort, String assocName,
IpChannelType ipChannelType, String extraHostAddresses) throws Exception {
this.wrappedSctpManagement.addAssociation(hostAddress, hostPort, peerAddress, peerPort, assocName, ipChannelType,
extraHostAddresses != null ? extraHostAddresses.split(",") : null);
return null;
}

@vetss vetss added this to the 3.0.0 milestone Mar 13, 2016
@vetss vetss changed the title But in GUI - sctpExtraHostAddress list for SCTP server is not set as empty after empty String Bug in GUI - sctpExtraHostAddress list for SCTP server is not set as empty after empty String Mar 13, 2016
vetss pushed a commit to vetss/jss7 that referenced this issue May 3, 2016
…SCTP server

is not set as empty after empty String
vetss pushed a commit to vetss/jss7 that referenced this issue May 3, 2016
…SCTP server

is not set as empty after empty String
@vetss
Copy link
Contributor Author

vetss commented May 3, 2016

Fixed by
d84f88b

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants