Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use version numbering in Webrtcomm library #28

Open
atsakiridis opened this issue Mar 7, 2016 · 2 comments
Open

Use version numbering in Webrtcomm library #28

atsakiridis opened this issue Mar 7, 2016 · 2 comments
Labels
Epic
Milestone
1.0.0 BETA5 release

Comments

@atsakiridis
Copy link
Collaborator

Right now, a user only has the Olympus version as a lead in the SIP 'User-Agent' string:

User-Agent: TelScale RTM Olympus/1.0.0

We should automate the generation of an auto-increasing version number in CI/CD and make sure we can easily see it in the JS logs or SIP requests (ideally the User-Agent should show both Olympus + SDK version)
@atsakiridis atsakiridis added this to the 1.0.0 GA release milestone Mar 31, 2016
@atsakiridis
Copy link
Collaborator Author

After discussion with @gvagenas we decided to have the User-Agent string configurable. And if not set show the following info:

  • Browser version (and name)
  • Olympus version
  • SDK version

For example:
User-Agent: Chrome 49.0.2623.87 (64-bit), TelScale RTM Olympus/1.0.0, Webrtcomm 1.0.0

@atsakiridis atsakiridis mentioned this issue Oct 18, 2016
Open
@atsakiridis atsakiridis mentioned this issue Feb 23, 2017
Open
@atsakiridis
Copy link
Collaborator Author

First part broken down into: #91, once that is done and we have clear picture we can open another one to automate incrementing

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Epic
Projects
None yet
Milestone
1.0.0 BETA5 release
Development

No branches or pull requests
1 participant
@atsakiridis