-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Read fresh metadata for unmodified files #2252
Conversation
Codecov Report
@@ Coverage Diff @@
## master #2252 +/- ##
==========================================
+ Coverage 50.8% 50.91% +0.11%
==========================================
Files 178 178
Lines 14530 14533 +3
==========================================
+ Hits 7382 7400 +18
+ Misses 6080 6059 -21
- Partials 1068 1074 +6
Continue to review full report at Codecov.
|
Read fresh metadata for unmodified files
The test for this fails if the system has SELinux enabled:
Having a default ACL on /tmp will also trigger the problem, with a My idea for fixing this is to copy the |
Oh, thanks for the hint. I'll fix the Windows tests first, then we'll see about these. |
FYI: I've fixed this (more or less accidentally) in #2266 by setting the field |
What is the purpose of this change? What does it change?
Restic took all metadata for files which were detected as unmodified, not
taking into account changed metadata (ownership, mode). This PR corrects it,
only the list of blobs (=the content) is taken from the previous file, the
metadata is read anew.
Was the change discussed in an issue or in the forum before?
Closes #2249
Checklist
changelog/unreleased/
that describes the changes for our users (template here)gofmt
on the code in all commits