Fix tests on Windows #2266
Merged
Fix tests on Windows #2266
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since I could not remember what the value for `Check` means this commit renames it to `SameFile`: when set to true, the test should make sure that `FileChanged` should return false (=file is unmodified).
Move all Archiver tests back into `archiver_test.go` and add some tiny helpers to mock what `lstat` returns (for Windows and Unix separately).
Windows does not have a concept of a `change time` in the sense as Unix has it: the field `CreationTime` of the `Win32FileAttributeData` struct is not updated when attributes or content is changed. So from now on we're using the `LastWriteTime` as the `change time` on Windows.
Codecov Report
@@ Coverage Diff @@
## master #2266 +/- ##
=========================================
+ Coverage 50.88% 51% +0.12%
=========================================
Files 178 178
Lines 14536 14536
=========================================
+ Hits 7396 7414 +18
+ Misses 6073 6051 -22
- Partials 1067 1071 +4
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this change? What does it change?
It corrects some assumptions on Windows, so the tests will pass again. Probably the biggest change is that we're now using
LastWriteTimeasctime(instead ofCreationTime, which isn't updated). For older releases of restic this was not relevant since we weren't using thectimeat all, we only recently integrated checking thectimein #2212.If you want to follow along, please read the individual commits instead of the whole diff.
Was the change discussed in an issue or in the forum before?
#2257 (comment)
Checklist
changelog/unreleased/that describes the changes for our users (template here)gofmton the code in all commits