Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restify:ServerResponse.prototype.getHeaders clashes nodejs:OutgoingMessage.prototype._headers #1470

Closed
3 tasks done
osher opened this issue Aug 30, 2017 · 3 comments
Closed
3 tasks done

Comments

@osher
Copy link

osher commented Aug 30, 2017

  • Used appropriate template for the issue type
  • Searched both open and closed issues for duplicates of this issue
  • Title adequately and concisely reflects the feature or the bug

Bug Report

Restify Version

4.3.1

Node.js Version

8.4

Expected behaviour

This section details what you expected restify to do based on the code that you wrote
the headers should return and the flow should continue

Actual behaviour

This section details what restify actually did when you ran your code
stack overflow, and then a crash

Repro case

call res._headers on node 8.4
https://travis-ci.org/theganyo/swagger-node-runner/jobs/269952760

Cause

Fatal Recursion -
Restify:ServerResponse.prototype.getHeaders
nodejs@8.4:OutgoingMessage.prototype._headers
are calling each other recursively.

Are you willing and able to fix this?

no
just FYI

@osher
Copy link
Author

osher commented Aug 31, 2017

nodejs/node#15091

@osher
Copy link
Author

osher commented Aug 31, 2017

hmmm... a leftover comment mark made this report look empty - I fixed that...

@retrohacker
Copy link
Member

Landed in #1473

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants