Fix bug with no setting ResponseStatus.Aborted if the request was aborted just after starting. #380
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| private HttpResponse CreateErrorResponse(Exception ex) | ||
| { | ||
| var response = new HttpResponse(); | ||
| if (ex is WebException && ((WebException)ex).Status == WebExceptionStatus.RequestCanceled) |
There was a problem hiding this comment.
This results in two casts. Perhaps:
var webException = ex as WebException;
if (webException != null && webException.Status == WebExceptionStatus.RequestCancelled)...
|
I really like consolidating the creation of the response in a method, but I had some concerns about the actual implementation. |
haacked
added a commit
that referenced
this pull request
Sep 7, 2013
Fix bug with no setting ResponseStatus.Aborted if the request was aborted just after starting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If the request was aborted just after starting, then callback gets response with ResponseStatus == ResponseStatus.TimedOut or ResponseStatus == ResponseStatus.Error, but not ResponseStatus == ResponseStatus.Aborted.