Changed JsonDeserializer to look for and honor DeserializeAs attribute #406
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -71,7 +71,24 @@ private void Map(object target, IDictionary<string, object> data) | |||
| { | |||
| var type = prop.PropertyType; | |||
|
|
|||
| var name = prop.Name; | |||
| //var name = prop.Name; | |||
| string name = String.Empty; | |||
There was a problem hiding this comment.
Please fix indentation. RestSharp uses tabs instead of spaces. I know! It's a travesty. I haven't gotten around to fixing it yet.
|
Looks good! Just a couple minor tweaks suggested. |
|
Tweaked based on feedback. |
| @@ -192,6 +192,18 @@ public void Can_Deserialize_Elements_to_Nullable_Values() | |||
| Assert.Equal(new Guid(GuidString), output.UniqueId); | |||
| } | |||
|
|
|||
| [Fact] | |||
There was a problem hiding this comment.
This test also needs its indentation fixed.
4 tasks
|
Can you remove the last commit and submit that as a separate PR? It has nothing to do with this PR. Thanks! |
|
My bad...removed. |
haacked
added a commit
that referenced
this pull request
Sep 4, 2013
Changed JsonDeserializer to look for and honor DeserializeAs attribute
|
Thanks for your contribution and for bearing with me! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I need to be able to map a property name on my model type to a different name in Json when deserializing. I'm reusing the DeserializeAs attribute to do this and just having the JsonDeserialize check to see if the attribute exists, and if it does prefer that name over the models property name. I added a test for this as well.