Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accents should not place simple symbols in a ParseNode::Group #4

Closed
cbreeden opened this issue Dec 8, 2016 · 1 comment
Closed

Comments

@cbreeden
Copy link
Collaborator

cbreeden commented Dec 8, 2016

Currently, \hat{A} will place A in a ParseNode::Group, and \hat A will simply place a ParseNode::Symbol in the nucleus of the ParseNode::Accent.

As a macro argument, the opening and closing braces should be transparent to the processing of ParseNode::Accent. In particular, this will give false positives to nucleus.is_symbol when processing superscripts.

It may be worth considering changing the nucleus field of an Accent to a Vec<ParseNode> instead.

@cbreeden cbreeden mentioned this issue Dec 8, 2016
14 tasks
@cbreeden
Copy link
Collaborator Author

Changing from Box<ParseNode> to Vec<ParseNode> did the trick reference: 39c1216

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant