Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add error for an overflowing operation on TTL and timestamp #21

Closed
brycx opened this issue Nov 29, 2020 · 0 comments
Closed

Add error for an overflowing operation on TTL and timestamp #21

brycx opened this issue Nov 29, 2020 · 0 comments

Comments

@brycx
Copy link
Collaborator

brycx commented Nov 29, 2020

I think it would be best to return an error, instead of panic, when ttl + timestamp would overflow. Otherwise, someone might construct tokens with the timestamp maximum value to have the validating side panic on each parsing (if validating side sets non-zero ttl).

@brycx brycx closed this as completed in 1a69d7a Nov 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant