Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

import not matching what's expected #1771

Closed
DrewDennison opened this issue Oct 1, 2020 · 6 comments · Fixed by #2094
Closed

import not matching what's expected #1771

DrewDennison opened this issue Oct 1, 2020 · 6 comments · Fixed by #2094
Assignees
@aryx @ievans @DrewDennison
Labels
bug Something isn't working lang:python priority:medium user:external requested by someone outside of r2c

Comments

@DrewDennison
Copy link
Member

Describe the bug
A clear and concise description of what the bug is.

https://semgrep.dev/s/KdNY/ fails to match the expected lines

To Reproduce
Steps to reproduce the behavior, ideally a link to https://semgrep.dev: https://semgrep.dev/s/KdNY/

Expected behavior
A clear and concise description of what you expected to happen.

$X should include the full path or there should be a way to match the fully qualified import path

$X is just matching a in import a.auth
@DrewDennison DrewDennison added bug Something isn't working user:external requested by someone outside of r2c labels Oct 1, 2020
@mschwager
Copy link
Contributor

See also: #975 (comment)

@aryx
Copy link
Collaborator

aryx commented Oct 2, 2020

I knew you would comment matt :)

@mschwager
Copy link
Contributor

I knew you would comment matt :)

Hah, that's what I'm here for!

@DrewDennison
Copy link
Member Author

more context: https://r2c-community.slack.com/archives/GVB6L4HHC/p1601592049009200

@ievans ievans mentioned this issue Nov 3, 2020
Open
@nbrahms nbrahms mentioned this issue Nov 12, 2020
Closed
@aryx
Copy link
Collaborator

aryx commented Nov 18, 2020

Ok I think I've figured it out! Should be able to fix that soon as well as many related import and aliasing issues.

aryx added a commit that referenced this issue Nov 19, 2020
@aryx
Correctly bind a metavariable in an import to the fully qualified name
04bdde9 
Fixes #1771

This should also help
#975

Test plan:

$ semgrep -f /tmp/test2.yml tests/python/import_metavar_fullpath.py
running 1 rules...
tests/python/import_metavar_fullpath.py
severity:error rule:tmp.import-auth: spooky import

12:import a.auth
14:import b.auth
16:import a.b.auth
ran 1 rules on 1 files: 3 findings
@aryx aryx mentioned this issue Nov 19, 2020
Merged
aryx added a commit that referenced this issue Nov 19, 2020
@aryx
Correctly bind a metavariable in an import to the fully qualified name (
69c79e4 
#2094)

Fixes #1771

This should also help
#975

Test plan:

$ semgrep -f /tmp/test2.yml tests/python/import_metavar_fullpath.py
running 1 rules...
tests/python/import_metavar_fullpath.py
severity:error rule:tmp.import-auth: spooky import

12:import a.auth
14:import b.auth
16:import a.b.auth
ran 1 rules on 1 files: 3 findings
@aryx
Copy link
Collaborator

aryx commented Nov 19, 2020

This works now on develop: https://semgrep.dev/s/KdNY/?version=develop

@Isaac0616 Isaac0616 mentioned this issue Apr 22, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aryx aryx

@ievans ievans

@DrewDennison DrewDennison

Labels
bug Something isn't working lang:python priority:medium user:external requested by someone outside of r2c
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Correctly bind a metavariable in an import to the fully qualified name semgrep/semgrep
5 participants
@aryx @ievans @DrewDennison @mschwager @nbrahms