Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New hide ads toggles #37

Closed
ghost opened this issue Jul 1, 2022 · 10 comments
Closed

New hide ads toggles #37

ghost opened this issue Jul 1, 2022 · 10 comments
Assignees

Comments

@ghost
Copy link

ghost commented Jul 1, 2022

Based on recent additions to this file: https://github.com/revanced/revanced-integrations/blob/main/app/src/main/java/app/revanced/integrations/adremover/LithoAdRemoval.java

some toggles are not yet available on settings enum:
https://github.com/revanced/revanced-integrations/blob/main/app/src/main/java/app/revanced/integrations/settings/SettingsEnum.java

@ghost
Copy link
Author

ghost commented Jul 1, 2022

@TheJeterLP

@TheJeterLP
Copy link
Contributor

can you point out which ones are not?

@ghost
Copy link
Author

ghost commented Jul 1, 2022

can you point out which ones are not?

From what I can see inside this repo...practically all toggles are missing from enum and settings method.

@TheJeterLP
Copy link
Contributor

can you point out which ones are not?

From what I can see inside this repo...practically all toggles are missing from enum and settings method.

Because they never were. There was no settings for that in Vanced. You could disable all ads or none

@ghost
Copy link
Author

ghost commented Jul 1, 2022

can you point out which ones are not?

From what I can see inside this repo...practically all toggles are missing from enum and settings method.

Because they never were. There was no settings for that in Vanced. You could disable all ads or none

Wut? Vanced give the ability to disable or enable selective litho ads. 🤷‍♂️

@ghost
Copy link
Author

ghost commented Jul 1, 2022

...also, without toggles, litho ads removal won't work, because they rely on boolean keys perpetually set to false.

@ghost
Copy link
Author

ghost commented Jul 1, 2022

This is how litho settings looks on the latest version of Vanced (this also means that the aready exists "home ads" toggle should be merged with this):

RtUnzJj

@TheJeterLP
Copy link
Contributor

This is how litho settings looks on the latest version of Vanced (this also means that the aready exists "home ads" toggle should be merged with this):

RtUnzJj

Hmm yes I see. Well, in XGlobals were no settings for that. So I have to add those all to the enum too then. Anyways, it's late for me, so I'm going to start on that the next few days

@ghost
Copy link
Author

ghost commented Jul 1, 2022

This is how litho settings looks on the latest version of Vanced (this also means that the aready exists "home ads" toggle should be merged with this):
RtUnzJj

Hmm yes I see. Well, in XGlobals were no settings for that. So I have to add those all to the enum too then. Anyways, it's late for me, so I'm going to start on that the next few days

Take your time. 👍

P.S: Give also a look to the file "revanced_prefs.xml" for further info (and additions) about litho ads.

@TheJeterLP
Copy link
Contributor

Is being worked on in #48

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant