bug: tasteBuilder-remover patch failes in 5.17.51 YTMusic

[shivanshvermak]

Type

Error while patching

Bug description

CLI: v2.9.1
Patches: v2.33.0
Integrations: v0.31.1
YTMusic version: 5.17.51

Steps to reproduce

Just try patching YTMusic using CLI, tastebuilder patch fails.

Relevant log output

SEVERE: tasteBuilder-remover failed:
app.revanced.patcher.patch.PatchResultError: taste-builder-constructor-fingerprint has not been resolved yet.
        at app.revanced.patcher.Patcher.applyPatch(Patcher.kt:301)
        at app.revanced.patcher.Patcher.access$applyPatch(Patcher.kt:44)
        at app.revanced.patcher.Patcher$applyPatches$1.invokeSuspend(Patcher.kt:317)
        at kotlin.coroutines.jvm.internal.BaseContinuationImpl.resumeWith(ContinuationImpl.kt:33)
        at kotlin.sequences.SequenceBuilderIterator.hasNext(SequenceBuilder.kt:127)
        at app.revanced.utils.patcher.PatcherKt.applyPatchesVerbose(Patcher.kt:92)
        at app.revanced.cli.patcher.Patcher.start$revanced_cli(Patcher.kt:22)
        at app.revanced.cli.command.MainCommand.run(MainCommand.kt:160)
        at picocli.CommandLine.executeUserObject(CommandLine.java:1939)
        at picocli.CommandLine.access$1300(CommandLine.java:145)
        at picocli.CommandLine$RunLast.executeUserObjectOfLastSubcommandWithSameParent(CommandLine.java:2358)
        at picocli.CommandLine$RunLast.handle(CommandLine.java:2352)
        at picocli.CommandLine$RunLast.handle(CommandLine.java:2314)
        at picocli.CommandLine$AbstractParseResultHandler.execute(CommandLine.java:2179)
        at picocli.CommandLine$RunLast.execute(CommandLine.java:2316)
        at picocli.CommandLine.execute(CommandLine.java:2078)
        at app.revanced.cli.main.MainKt.main(Main.kt:7)
Caused by: java.lang.Exception: taste-builder-constructor-fingerprint has not been resolved yet.
        at app.revanced.patcher.fingerprint.method.impl.MethodFingerprint.getResult(MethodFingerprint.kt:37)
        at app.revanced.patches.music.layout.tastebuilder.patch.RemoveTasteBuilderPatch.execute(RemoveTasteBuilderPatch.kt:27)
        at app.revanced.patches.music.layout.tastebuilder.patch.RemoveTasteBuilderPatch.execute(RemoveTasteBuilderPatch.kt:16)
        at app.revanced.patcher.Patcher.applyPatch(Patcher.kt:296)
        ... 16 more

Screenshots or videos

Solution

No response

Additional context

No response

[oSumAtrIX]

@epicsampler Was this tested?

[ghost]

@shivanshkverma In case you used the --experimental flag - leave it off (5.17.51 is supported now) and you should not run into this error

@oSumAtrIX

Was this tested?

tastebuilder patch doesn't support 5.17 for a reason, note from PR:
c303589#diff-03aa6ead4b178e9383c573664048494ca55312f11a292185015ce899ee44c1adR6-R10