-
Notifications
You must be signed in to change notification settings - Fork 90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
After bdd925b20 plugin lost the ability to run using defaults #63
Comments
Fixed at: |
That prior commit has a bug plus the entire point was to fix it so it reads resources like jars. Pretty sure the javascript formatter is broke this way. We should be able to do both...no settings plus all other options. Sent by Outlook for Android On Fri, Aug 7, 2015 at 4:02 PM -0700, "Marvin Froeder" notifications@github.com wrote: Reply to this email directly or view it on GitHub: |
Branch revert now exists for this as the original velo-merge was removed as it is in master. There were notes of merge conflicts so that will need rebased and looked at further. |
Marked as both a bug and enhancement given the changes were to retain original functionality before merge and it's a loss on the other end so it sort of fits both types. |
agreed |
@velo ok maybe this isn't fixed yet entirely. It no longer fails for missing setup but it actually has nothing to default back too. The only thing I can think in the code it attempts to do is setting some compilation level items. However, that section is not reachable code. I suspect you are referring to this code snippit. Can you confirm? If so, should this apply for both java and javascript or everything in general?
|
Above code is not reachable. Reviewed overall code. That was set in two places. Both were not reachable. I have reconfigured this. I'll open a new ticket regarding this issue. I'm closing this one. |
By reverting bdd925b I can run the plugin w/o any eclipse config.xml
If none is found, it does fall back to eclipse default configuration, which is, a good maven CoC practice.
The text was updated successfully, but these errors were encountered: