Made eclipse config.xml files optional. #64
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Revert "Rework resource usage" This reverts commit bdd925b.
| @@ -583,7 +604,7 @@ private void createCodeFormatter() throws MojoExecutionException { | |||
| try { | |||
| this.resourceManager.addSearchPath(FileResourceLoader.ID, | |||
| this.basedir.getAbsolutePath()); | |||
| configInput = this.resourceManager.getResourceAsInputStream(newConfigFile); | |||
| configInput = this.resourceManager.getResourceAsInputStream(this.configFile); | |||
There was a problem hiding this comment.
This was the bug I was mentioning. The 'this' reference here is to the wrong field which would otherwise break usage for javascript anyway. The this should be removed. It should be using the 'configFile directly passed into the private method.
|
It appears to me this was already done on master. I found a few other minor related glitches in this for error logging. Should we close this PR now? |
|
No, this was not done... Since reverting was going to break other stuff I left it behind. |
|
OK - I was looking at that wrong. You are correct. This wasn't done. It can stay for now :) |
|
Interesting. velo-merge deleting deleted the PR. It did put a revert branch out there with the changes so they are not lost. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert "Rework resource usage"
This reverts commit bdd925b.