Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Action fails with "fail to parse diff" error if PR touches more than 300 files. #124

Closed
menzenski opened this issue Apr 24, 2024 · 2 comments · Fixed by #131
Closed

Action fails with "fail to parse diff" error if PR touches more than 300 files. #124

menzenski opened this issue Apr 24, 2024 · 2 comments · Fixed by #131

Comments

@menzenski
Copy link

We're using this action as a pull request check in a repository that sees a lot of autogenerated PRs touching many configuration files. If more than 300 files are changed by a PR, this action fails with:

reviewdog: post failed for actionlint: fail to parse diff: GET https://api.github.com/repos/<ORG>/<REPO>/pulls/380: 406 Sorry, the diff exceeded the maximum number of files (300). Consider using 'List pull requests files' API or locally cloning the repository instead. [{Resource:PullRequest Field:diff Code:too_large Message:}]

Is there a workaround here?

@colatkinson
Copy link

It looks like there was a partial fix in 0.17.4 (issue: reviewdog/reviewdog#1696, PR: reviewdog/reviewdog#1714). That said, the bump PR is still outstanding (#123), and based on the issue comments it appears that there are still some unhandled cases.

That said hopefully a maintainer/someone affiliated with the project can correct me if I'm wrong here, I was just looking into this because I also hit this issue.

@massongit
Copy link
Contributor

massongit commented Jun 4, 2024

I applied reviewdog v0.17.5 include reviewdog/reviewdog#1722 and released reviewdog/action-actionlint.
Therefore, I think this problem has been resolved.

@massongit massongit linked a pull request Jun 4, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants