Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add possibility to override/extend version name and version separator #17

Closed
skarzi opened this issue Nov 7, 2020 · 2 comments
Closed

Comments

@skarzi
Copy link
Member

skarzi commented Nov 7, 2020

Hi 👋

thanks for super GitHub action!

It would be great to have the possibility to replace (or extend) regexp of the separator used to separate version name (e.g REVIEWDOG_VERSION) and version (e.g. 0.1.0) - currently it's equal to (=|:?\s+) - which is probably fine for most cases, but, for instance, not when you want to update the value in the file where each line is formatted like plugin-name:1.2.3.

It can be done by some action's input e.g. separator_regexp: ':\s*'.
Such a configuration option will make depup action much more versatile

@skarzi skarzi changed the title add possibility to extend version name and version separators add possibility to override/extend version name and version separator Nov 7, 2020
@rickstaa
Copy link
Member

@skarzi I think pull request #21 adds this feature.

@skarzi
Copy link
Member Author

skarzi commented Dec 13, 2020

yes, currently a majority of cases are handled properly!

@skarzi skarzi closed this as completed Dec 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants