-
-
Notifications
You must be signed in to change notification settings - Fork 414
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Failed linter on GitHub Actions run does not cause check to fail when fail_on_error is true #949
Comments
Some repositories seem to fail the check successfully without running exit command. example
I haven't checked all the repositories yet. I think it is better to run exit command in a unified manner than to think whether it is necessary to run exit command because it can prevent problems like this one. At least I'm thinking of adding it to the template repository. |
Issue Status: 1. Open 2. Started 3. Submitted 4. Done This issue now has a funding of 0.001 ETH (2.25 USD @ $2245.09/ETH) attached to it.
|
Issue Status: 1. Open 2. Started 3. Submitted 4. Done Work has been started. These users each claimed they can complete the work by 265 years, 5 months from now. 1) richcrown619 has started work. I will to support this project at all cost Learn more on the Gitcoin Issue Details page. |
Issue Status: 1. Open 2. Started 3. Submitted 4. Done Work for 0.001 ETH has been submitted by:
|
What's the state of this one. I have got es-lint errors and am exceeding --max-warnings and reviewdog/action-eslint is not failing my build. |
Hi there 👋 stylelint seems to have it, but yet the action is not failing when stylelint fails. Any idea? https://github.com/reviewdog/action-stylelint/blob/master/script.sh#L40 |
@Djiit Can you share a repository that isn't working properly? |
ReviewDog help request: reviewdog/reviewdog#949
Many repositories need to fix, so please help if you like.
If you could help, it would be helpful if you could comment before starting the work not to overlapping.
Fix example
Run exit command after lint.
reviewdog/action-golangci-lint#77
Todo
I checked the ones that are runnning exit command.
If
fail_on_error
is not exist in input, please add.Template
Common
Text (e.g. Markdown)
Docker
Dockerfile
.Env
.env
files.Shell script
Go
JavaScript
CSS
Vim script
Terraform
YAML
Ruby
Python
Kotlin
Android Lint
Ansible
ref: https://github.com/reviewdog/reviewdog#public-reviewdog-github-actions
The text was updated successfully, but these errors were encountered: