Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The new Advanced search form - a few suggestions #77

Closed
gizellos opened this issue Oct 29, 2017 · 5 comments
Closed

The new Advanced search form - a few suggestions #77

gizellos opened this issue Oct 29, 2017 · 5 comments

Comments

@gizellos
Copy link

gizellos commented Oct 29, 2017

The idea of the new Advanced search is good but I have a few suggestions.

  1. The form is too small. For example, there can be written only 6 letters m. It is not enough. Do it a bit wider.
  2. Since the form is on the left side of the menu, the menu has to be moved after the form is loaded which is very annoying. I suggest to move it beside the Encrypted giveaway button - to the right side.
  3. The form has it's duplicate on the giveaway lists pages. I suggest to remove the old forms in the left side (BTW the old form doesn't have the type filter).
@rafaelgomesxyz
Copy link
Owner

You mean Quick Giveaway Search?

  1. If the form is too wide it would look bad for users with small screens.
  2. Don't you think putting it on the right side would feel too out of place?
  3. Doesn't hurt anyone to have that form there, it's still useful.

@gizellos
Copy link
Author

gizellos commented Oct 29, 2017

Yes I mean it.

  1. OK, you could make it wider only if the written text is almost wider than the field (or if the text field is activated). But without moving the rest of menu. The text field would be put over it (Higher z-index? Position: absolute?)
  2. Yes, it would not be an ideal. You are right.
  3. Yes but it is pointless to have it twice. The DOM is more complicated, the page is generated more slowly, users with lower resolution have to unnecessarily scroll down to see the menu below it, it doesn't look good if there are two Search fields so close each other...

@rafaelgomesxyz
Copy link
Owner

rafaelgomesxyz commented Oct 29, 2017

It's not pointless, they're not the same thing, the quick giveaway search allows you to search on other pages and saves your settings, so you can use it differently than the normal search. And having the old form does not affect the speed that the page is generated at all, I don't know what you're talking about.

@rafaelgomesxyz
Copy link
Owner

Made some alterations, hope it's better now.

@gizellos
Copy link
Author

Yes, it is, thanks. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants