Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rebuild permissions system. #104

Closed
insertish opened this issue Nov 1, 2021 · 7 comments
Closed

Rebuild permissions system. #104

insertish opened this issue Nov 1, 2021 · 7 comments
Assignees
Labels
enhancement New feature or request

Comments

@insertish
Copy link
Member

insertish commented Nov 1, 2021

For #6 and #4.

Current hierarchy:
image

@insertish insertish added enhancement New feature or request BLOCKED labels Nov 1, 2021
@insertish insertish added this to the 0.5.3: Backend Overhaul milestone Nov 1, 2021
@insertish
Copy link
Member Author

Ideally, we could build it similar to how Discord inherits permissions so that there's not much of a learning curve.

https://support.discord.com/hc/en-us/articles/206141927-How-is-the-permission-hierarchy-structured-

Although, it would be worth adding role permission deny.

@sairam4123
Copy link

sairam4123 commented Feb 5, 2022

Please do make sure that roles follow Hierarchy and override lower roles.

@erkinalp
Copy link

erkinalp commented Feb 13, 2022

Ideally, we could build it similar to how Discord inherits permissions so that there's not much of a learning curve.

Discord does not inherit permissions from the parent category. Revolt could depart from that and actually inherit from the parent category. Also to mention, it uses an "explicit allow wins" system which is inconvenient in a lot of respects. "Explicit deny wins" is better suited to express permissions for any serious use.

@insertish
Copy link
Member Author

Now closes #4 as of revoltchat/quark@d2e49a6. (This repo will be public once license is added.)

@insertish
Copy link
Member Author

The following does not account for categories yet, still sorting out the data model.
Current permission hierarchy looks like this:
image

I am currently working to implement this.

@insertish insertish self-assigned this Feb 22, 2022
@erkinalp
Copy link

Allows then denies, so explicit deny wins. This seems sane to me. After all, lockout is better than power out of control.

@insertish
Copy link
Member Author

Fix relevant issue revoltchat/revite#84 while we're at it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants