Skip to content

Commit

Permalink
Fix: Fixed detail element in friends list
Browse files Browse the repository at this point in the history
  • Loading branch information
nizune committed Jul 4, 2021
1 parent e94d824 commit 652736c
Show file tree
Hide file tree
Showing 3 changed files with 37 additions and 12 deletions.
10 changes: 4 additions & 6 deletions src/components/common/CollapsibleSection.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -39,12 +39,10 @@ export default function CollapsibleSection({ id, defaultValue, summary, children
onToggle={e => setState(e.currentTarget.open)}
{...detailsProps}>
<summary>
<ChevronDown size={20} />
{ summary }
{/*<Overline type="subtle" className="overline">*/}
{/*<div className="title">*/}
{/*</div>*/}
{/*</Overline>*/}
<div class="padding">
<ChevronDown size={20} />
{ summary }
</div>
</summary>
{ children }
</Details>
Expand Down
37 changes: 32 additions & 5 deletions src/components/ui/Details.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -9,23 +9,50 @@ export default styled.details<{ sticky?: boolean, large?: boolean }>`
` }
${ props => props.large && css`
padding: 5px 0;
/*padding: 5px 0;*/
background: var(--primary-background);
color: var(--secondary-foreground);
.padding { /*TOFIX: make this applicable only for the friends list menu, DO NOT REMOVE.*/
display: flex;
align-items: center;
padding: 5px 0;
margin: 0.8em 0px 0.4em;
cursor: pointer;
}
` }
outline: none;
display: flex;
cursor: pointer;
list-style: none;
align-items: center;
transition: .2s opacity;
font-size: 12px;
font-weight: 600;
text-transform: uppercase;
&::marker, &::-webkit-details-marker {
display: none;
}
> svg {
flex-shrink: 0;
transition: .2s ease transform;
.title {
flex-grow: 1;
margin-top: 1px;
text-overflow: ellipsis;
overflow: hidden;
white-space: nowrap;
}
.padding {
display: flex;
align-items: center;
> svg {
flex-shrink: 0;
margin-inline-end: 4px;
transition: .2s ease transform;
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion src/pages/friends/Friends.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ export default function Friends() {
id={`friends_${section_id}`}
defaultValue={true}
sticky large
summary={<Overline type="subtle" className="overline"><Text id={i18n} />{ list.length }</Overline>}>
summary={<div class="title"><Text id={i18n} />{ list.length }</div>}>
{ list.map(x => <Friend key={x._id} user={x} />) }
</CollapsibleSection>
)
Expand Down

0 comments on commit 652736c

Please sign in to comment.