Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the possibility to add a 'media' folder containing graphics for the theme. #24

Closed
QazCetelic opened this issue Dec 30, 2021 · 3 comments
Labels
enhancement New feature or request

Comments

@QazCetelic
Copy link

I use a few background images (copyleft-license). However, it currently requires hot-linking to an external third party service.
Adding a possibility to ship the graphics with the theme itself could solve this.

@brecert
Copy link
Contributor

brecert commented Jan 3, 2022

It's not ideal, however you can embed images within the css itself using Data URIs.

@insertish insertish added the enhancement New feature or request label Jan 3, 2022
@QazCetelic
Copy link
Author

It's not ideal, however you can embed images within the css itself using Data URIs.

I have ended up uploading it to Revolt and then using the image link to prevent the CSS file from becoming 100KB+.

@Rexogamer
Copy link
Member

Rexogamer commented Jan 16, 2023

Files/media should be uploaded to Revolt, then linked to by the CSS - aside from anything, this prevents any CORS issues. As attribution isn't currently easy to include, please ensure any files are available under a permissive license ^^

@Rexogamer Rexogamer closed this as not planned Won't fix, can't repro, duplicate, stale Jan 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants