Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

friendship_request_created signal uses wrong model as sender #4

Closed
ppp23 opened this issue Feb 16, 2013 · 2 comments
Closed

friendship_request_created signal uses wrong model as sender #4

ppp23 opened this issue Feb 16, 2013 · 2 comments

Comments

@ppp23
Copy link
Contributor

ppp23 commented Feb 16, 2013

as documented here: https://github.com/revsys/django-friendship/blob/master/docs/signals.rst friendship_request_created should use the FriendshipRequest instance as sender, but currently the FriendshipManager is used:

https://github.com/revsys/django-friendship/blob/master/friendship/models.py#L204
@ppp23
Copy link
Contributor Author

ppp23 commented Feb 16, 2013

i fixed it here: ppp23@9e8efde

@ppp23
Copy link
Contributor Author

ppp23 commented Feb 20, 2013

btw. the sender should not be the class and the instance should be given as instance parameter to stay with the expected behaviour of django

@frankwiles frankwiles mentioned this issue May 6, 2014
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@frankwiles @ppp23