Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

t/scm/git.t plans twice without git #1588

Closed
ferki opened this issue May 28, 2023 · 0 comments · Fixed by #1590
Closed

t/scm/git.t plans twice without git #1588

ferki opened this issue May 28, 2023 · 0 comments · Fixed by #1590
Labels
bug Confirmed bugs

Comments

@ferki
Copy link
Member

ferki commented May 28, 2023

Describe the bug

t/scm/git.t plans tests twice when git is not present on the system. See for example http://www.cpantesters.org/cpan/report/8c73ca94-6db7-1014-971a-cd3523496917.

Expected behavior

t/scm/git.t tests should skip properly when git is not present.

How to reproduce it

  1. Either uninstall git, rename git, or move git out of the PATH.
  2. Run prove -l t/scm/git.t.

Code example

No code example for this.

Additional context

No response

Rex version

1.14.2

Perl version

5.36.0

Operating system running rex

Gentoo

Operating system managed by rex

local

How rex was installed?

dzil install
@ferki ferki added the bug Confirmed bugs label May 28, 2023
@ferki ferki mentioned this issue May 28, 2023
Merged
5 tasks
@perlpunk perlpunk mentioned this issue Jun 1, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Confirmed bugs
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix skipping tests without git RexOps/Rex
1 participant
@ferki