Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Underflow in mkpasswd #12

Closed
mahkoh opened this issue Jan 18, 2014 · 1 comment
Closed

Underflow in mkpasswd #12

mahkoh opened this issue Jan 18, 2014 · 1 comment

Comments

@mahkoh
Copy link

mahkoh commented Jan 18, 2014

The comparison rounds < 0 in https://github.com/rfc1036/whois/blob/master/mkpasswd.c#L183 is a negative tautology since rounds is unsigned.

Unrelated: In 949 and 950 of whois.c the statement after the empty loops causes compiler warnings.
rfc1036 added a commit that referenced this issue Jan 19, 2014
@rfc1036
mkpasswd: fix an underflow in the parser for -R
83cb7e1 
Reported by mahkoh on github:
#12
@rfc1036
Copy link
Owner

rfc1036 commented Jan 19, 2014

Thank you, fixed.

@rfc1036 rfc1036 closed this as completed Jan 19, 2014
rfc1036 added a commit that referenced this issue Jan 19, 2014
@rfc1036
mkpasswd: fix an underflow in the parser for -R
f040a11 
Reported by mahkoh on github:
#12
weppos pushed a commit to weppos/whois-c that referenced this issue Dec 25, 2015
@rfc1036
mkpasswd: fix an underflow in the parser for -R
366ca9b 
Reported by mahkoh on github:
rfc1036#12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mahkoh @rfc1036