Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hf mf cload #51

Closed
iceman1001 opened this issue Nov 11, 2018 · 10 comments
Closed

hf mf cload #51

iceman1001 opened this issue Nov 11, 2018 · 10 comments
Labels
bug Something isn't working

Comments

@iceman1001
Copy link
Collaborator

Describe the bug
Since the name template change of filenames when saving dump files etc, the template starts with h , as in "hf-mf-UID.bin" or similar. All older commands still not adapted, they assume if first char is 'h' its a request for helptext.

To Reproduce
Steps to reproduce the behavior:

  1. create a dump, hf mf dump
  2. convert from bin to emul, script run dumptoemul -h
  3. try restoring onto magic card, hf mf cload hf-mf-ZZZZ

the help text is shown..

Expected behavior
Expected behavior is to load the file

Additional context
All older commands should have a param 'f' as for indicating a filename entry.
this is a breaking change from old style command which uses without a param but only filename.

Also all commands should be able to load eml/bin without having to choose. in fileutils.c should have support for auto-detect and load of those two kinds of formats. In the future I see also support for reading json,

@RfidResearchGroup RfidResearchGroup added the bug Something isn't working label Nov 11, 2018
@merlokk
Copy link
Contributor

merlokk commented Nov 11, 2018

json will be here with #50 and can be easily integrated into old parts of code

@RfidResearchGroup
Copy link
Collaborator

I'm adding some function stubs for you, in the process of unifying the load / save files from proxmark client.

@merlokk
Copy link
Contributor

merlokk commented Nov 11, 2018

ok)

@RfidResearchGroup
Copy link
Collaborator

alright then, Got a beginning for it. Load EML / BIN , but how to make a swap based on file existence? or?

@RfidResearchGroup
Copy link
Collaborator

6a21df3

@merlokk
Copy link
Contributor

merlokk commented Nov 14, 2018

#54

@iceman1001
Copy link
Collaborator Author

how are we doing with the json stuff?

1 similar comment
@iceman1001
Copy link
Collaborator Author

how are we doing with the json stuff?

@merlokk
Copy link
Contributor

merlokk commented Nov 24, 2018

not now( i was very busy at work. i think from Monday))))

@RfidResearchGroup
Copy link
Collaborator

Don't stress it.

iceman1001 pushed a commit that referenced this issue Oct 3, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants