earlyoom-1.6.1 fails tests

[pacho2]

I get this failures (attached full log)

--- FAIL: TestCli (0.16s)
    --- PASS: TestCli/-h (0.00s)
    --- PASS: TestCli/--help (0.00s)
    --- FAIL: TestCli/#00 (0.00s)
    --- FAIL: TestCli/-p (0.00s)
    --- PASS: TestCli/-v (0.00s)
    --- FAIL: TestCli/-d (0.00s)
    --- FAIL: TestCli/-m_1 (0.00s)
    --- PASS: TestCli/-m_0 (0.00s)
    --- PASS: TestCli/-m_-10 (0.00s)
    --- PASS: TestCli/-m_100 (0.00s)
    --- FAIL: TestCli/-s_2 (0.00s)
    --- FAIL: TestCli/-s_100 (0.00s)
    --- PASS: TestCli/-s_101 (0.00s)
    --- PASS: TestCli/-s_0 (0.00s)
    --- PASS: TestCli/-s_-10 (0.00s)
    --- FAIL: TestCli/-M_161043 (0.00s)
    --- PASS: TestCli/-M_9999999999999999 (0.00s)
    --- PASS: TestCli/-r=0 (0.10s)
    --- FAIL: TestCli/-r_0.1 (0.00s)
    --- FAIL: TestCli/--avoid_MyProcess1 (0.00s)
    --- FAIL: TestCli/--prefer_MyProcess2 (0.00s)
    --- FAIL: TestCli/-i (0.00s)
    --- PASS: TestCli/xyz (0.00s)
    --- PASS: TestCli/-i_1 (0.00s)
    --- FAIL: TestCli/-m_2,1 (0.00s)
    --- FAIL: TestCli/-m_1,2 (0.00s)
    --- PASS: TestCli/-m_1,-1 (0.00s)
    --- PASS: TestCli/-m_1000,-1000 (0.00s)
    --- FAIL: TestCli/-s_2,1 (0.00s)
    --- FAIL: TestCli/-s_1,2 (0.00s)
    --- FAIL: TestCli/-m_5,0 (0.00s)
    --- FAIL: TestCli/-m_5,9 (0.00s)
    --- PASS: TestCli/-M_-1 (0.00s)
    --- PASS: TestCli/-M_2147483648 (0.00s)
    --- PASS: TestCli/-M_4294967296 (0.00s)
    --- PASS: TestCli/-m_-1 (0.00s)
    --- PASS: TestCli/-m_2147483648 (0.00s)
    --- PASS: TestCli/-m_4294967296 (0.00s)
    --- PASS: TestCli/-S_-1 (0.00s)
    --- PASS: TestCli/-S_2147483648 (0.00s)
    --- PASS: TestCli/-S_4294967296 (0.00s)
    --- PASS: TestCli/-s_-1 (0.00s)
    --- PASS: TestCli/-s_2147483648 (0.00s)
    --- PASS: TestCli/-s_4294967296 (0.00s)
    --- FAIL: TestCli/-m_3.14 (0.00s)
    --- FAIL: TestCli/-m_7,3.14 (0.00s)
    --- FAIL: TestCli/-s_12.34 (0.00s)
    --- FAIL: TestCli/-m_10_-M_161043 (0.00s)
    --- FAIL: TestCli/-S_104816 (0.00s)
    --- FAIL: TestCli/-s_10_-S_104816 (0.00s)
=== RUN   TestRss
    testsuite_cli_test.go:213: rss above 1 MiB
    testsuite_cli_test.go:215: earlyoom RSS: 1868 kiB
--- FAIL: TestRss (0.00s)
=== RUN   TestI
--- PASS: TestI (0.03s)
=== RUN   TestParseTuple
warning: SIGTERM value 5.00 is below SIGKILL value 9.00, setting SIGTERM = SIGKILL = 9.00
warning: SIGTERM value 0.00 is below SIGKILL value 5.00, setting SIGTERM = SIGKILL = 5.00
warning: SIGTERM value 4.00 is below SIGKILL value 5.00, setting SIGTERM = SIGKILL = 5.00
--- PASS: TestParseTuple (0.00s)
=== RUN   TestIsAlive
--- PASS: TestIsAlive (0.00s)
=== RUN   Test_fix_truncated_utf8
--- PASS: Test_fix_truncated_utf8 (0.00s)
=== RUN   Test_get_vm_rss_kib
--- PASS: Test_get_vm_rss_kib (0.00s)
=== RUN   Test_get_oom_score
--- PASS: Test_get_oom_score (0.00s)
=== RUN   Test_get_comm
    testsuite_unit_test.go:138: process name "earlyoom-1.6.1."
--- PASS: Test_get_comm (0.00s)
FAIL
exit status 1
FAIL	_/var/tmp/portage/sys-apps/earlyoom-1.6.1/work/earlyoom-1.6.1	0.187s
make: *** [Makefile:86: test] Error 1

Thanks
error.txt

[hakavlad]

see also 1 alert https://lgtm.com/projects/g/rfjakob/earlyoom/alerts/?mode=list

[dcermak]

I have just tried to build earlyoom with tests enabled for openSUSE and the tests pass without issues on x86_64 and aarch64. However on i586, TestCli/-p fails consistently (see https://build.opensuse.org/package/live_build_log/home:dancermak:branches:Base:System/earlyoom/openSUSE_Factory/i586).

Also, the tests fail a lot on powerpc: https://build.opensuse.org/package/live_build_log/home:dancermak:branches:Base:System/earlyoom/openSUSE_Factory_PowerPC/ppc64le I am unfortunately not too sure what the issue could be here or whether earlyoom is even working on ppc?

[rfjakob]

I looked at errors.txt, and the actual problem is always the same:

testsuite_cli_test.go:176: Memory usage too high! actual rss: 1824, rssMax: 1024

For some reason, on your system, earlyoom uses more than the expected 1024 kiB of RSS memory. This is otherwise harmless.

What distribution do you test on?

[dcermak]

What distribution do you test on?

On opensuse Leap and Tumbleweed.