Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input: post-code-review #8

Closed
GoogleCodeExporter opened this issue Jun 4, 2015 · 5 comments
Closed

Input: post-code-review #8

GoogleCodeExporter opened this issue Jun 4, 2015 · 5 comments

Comments

@GoogleCodeExporter
Copy link

Bugs:
incorrect notify() handling in derived from input::Helper classes (as
Button,  and etc.)

Enhancements:
*use "boost::shared_ptr<Control>" instead of raw "Control*"
*InputImpl::Load change to LoadFromString
*std::list<CommandPtr> m_commands change to std::map<>

Remarks:
желательно использовать typedef для 
используемых сложных типов как Stl
контейнеры и итераторы
избыточное декарирование комментариев
избыточные комментарии (там где и так 
понятно, например на методы
Get,Destoy,Init)
использование паблик переменных в классе 
(Control)
в input::Input надо убрать сингельтон, заменив на 
статический Init(InputImpl*)
не аккуратность с форвард объявлениями. в 
результате InputImpl был всем виден.

Original issue reported on code.google.com by denis.o...@gmail.com on 12 May 2007 at 10:01

@GoogleCodeExporter
Copy link
Author

принял

Original comment by atru...@gmail.com on 13 May 2007 at 7:52

@GoogleCodeExporter
Copy link
Author

исправлен баг с notify

Original comment by atru...@gmail.com on 13 May 2007 at 8:25

  • Changed state: Started

@GoogleCodeExporter
Copy link
Author

[deleted comment]

1 similar comment
@GoogleCodeExporter
Copy link
Author

[deleted comment]

@GoogleCodeExporter
Copy link
Author

closed

Original comment by denis.o...@gmail.com on 15 Oct 2009 at 3:33

  • Changed state: Verified

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant