Convert :whitespace_elements into a Hash. #94
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will let developers to configure Sanitize to specify the
replacements for :whitespace_elements found in the input. Previously,
developers couldn't specify the text to be inserted before and after
the :whitespace_elements.
- updated :whitespace_elements to be a Hash rather than an Array.
- updated CleanElement#call to use appropriate replacements for the
element found instead of hardcoded space (' ').
- made sure existing tests were not broken and added new tests for the
functionality added by overriding replacement values for tags.
- updated README to reflect these changes.
NOTE: Changes are backwards compatible. Code will detect Array types
and will convert them into the new Hash format.
|
I like it! Thanks for the nice clean PR and tests. :) |
|
Merged into the dev-2.2.0 branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will let developers to configure Sanitize to specify the
replacements for :whitespace_elements found in the input. Previously,
developers couldn't specify the text to be inserted before and after
the :whitespace_elements.
element found instead of hardcoded space (' ').
functionality added by overriding replacement values for tags.
NOTE: Changes are backwards compatible. Code will detect Array types
and will convert them into the new Hash format.