-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
master since release has important fixes, and HA should bump the version #21
Comments
Looks like we have an actual release! Is there an HA PR to bump the version of webrtc-noise-gain? |
webrtc has been dropped in favor of microVAD: home-assistant/core#122861 |
Thanks for pointing that out. Well, that's unfortunate, and I guess we can move on to seeing if microVAD has portability bugs :-( Thanks for being cooperative about handling BSD patches. |
I expect there to be far fewer portability bugs. The codebase is less complex than WebRTC since it's only doing VAD, and I haven't needed to adjust any flags yet when compiling across Linux amd64/arm64/armv7/armv6 and macOS. I still need to build Windows wheels though. |
On NetBSD 10, I just created a venv and did |
The last release is more than 6 months ago, and there are fixes on master since then:
These take the module from not working to working on all the BSDs, and seem very low risk for other platforms.
Could you tag e.g. 1.2.4? That would allow bumping the version in HA.
The text was updated successfully, but these errors were encountered: