Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

master since release has important fixes, and HA should bump the version #21

Closed
gdt opened this issue Apr 16, 2024 · 5 comments
Closed
Assignees

Comments

@gdt
Copy link
Contributor

gdt commented Apr 16, 2024

The last release is more than 6 months ago, and there are fixes on master since then:

38a6d1e Add armv6/armv7 docker builds
a5ea46f setup.py: Include other BSDs in elif clause matching freebsd
f938874 Fix compile on musl
30a7ebe Fix build on FreeBSD.

These take the module from not working to working on all the BSDs, and seem very low risk for other platforms.

Could you tag e.g. 1.2.4? That would allow bumping the version in HA.

@synesthesiam synesthesiam self-assigned this Apr 16, 2024
@gdt gdt changed the title master since release has important fixes (release please!) master since release has important fixes, and HA should bump the version Jul 31, 2024
@gdt
Copy link
Contributor Author

gdt commented Jul 31, 2024

Looks like we have an actual release!

Is there an HA PR to bump the version of webrtc-noise-gain?

@synesthesiam
Copy link
Contributor

webrtc has been dropped in favor of microVAD: home-assistant/core#122861

@gdt
Copy link
Contributor Author

gdt commented Jul 31, 2024

Thanks for pointing that out. Well, that's unfortunate, and I guess we can move on to seeing if microVAD has portability bugs :-(

Thanks for being cooperative about handling BSD patches.

@gdt gdt closed this as completed Jul 31, 2024
@synesthesiam
Copy link
Contributor

I expect there to be far fewer portability bugs.

The codebase is less complex than WebRTC since it's only doing VAD, and I haven't needed to adjust any flags yet when compiling across Linux amd64/arm64/armv7/armv6 and macOS. I still need to build Windows wheels though.

@gdt
Copy link
Contributor Author

gdt commented Jul 31, 2024

On NetBSD 10, I just created a venv and did bin/pip install pymicro-vad which completed quickly and uninterestingly, so things are looking good. Thanks for the encouragement.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants