Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improved "environment" functionality - Tracking and control of loaded js/css libraries. #39

Closed
jwildfire opened this issue Feb 6, 2018 · 0 comments
Assignees
Milestone

Comments

@jwildfire
Copy link
Contributor

jwildfire commented Feb 6, 2018

Update: Keeping track of env objects was going to be a pain, so refactored to take a much simpler approach

Revised approach

CAT will display links to all loaded <link> and <script> tags under the environment section of the CAT controls. Link tags will have a toggle that allows the user to enable/disable links to see how css effects the charts. Users can add any css files they want to the page hosting the CAT instance to facilitate testing of different environments.

Not going to deal with "unloading" scripts at this time.

Original plan

Add support for new config.env option where config.env is an array with objects that have the following properties:

config.env.label - a human readable name for the environment
config.env.js - an array of paths for javascript to be loaded before rendering the chart
config.css.js - an array of paths for css to be loaded before renderering the chart

Each env option will appear in a drop down along with "none".

@jwildfire jwildfire added this to the v0.7.0 milestone Feb 6, 2018
jwildfire added a commit that referenced this issue Feb 13, 2018
@jwildfire jwildfire self-assigned this Feb 16, 2018
@jwildfire jwildfire changed the title Add support for different "environments" that pre-load specified js/css libraries. Improved "environment" functionality - Tracking and control of loaded js/css libraries. Feb 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant