Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ONNX providers for multiple contexts #1

Closed
rhysdg opened this issue Aug 19, 2022 · 2 comments
Closed

Update ONNX providers for multiple contexts #1

rhysdg opened this issue Aug 19, 2022 · 2 comments
Assignees
@rhysdg
Labels
bug Something isn't working enhancement New feature or request

Comments

@rhysdg
Copy link
Owner

rhysdg commented Aug 19, 2022

  • Add CPUExecutionProvide fallback within roberta_onnx
  • Currently passing testing within ubuntu-latest runner via our CI mechanism but fails with a clean CPU backed EC2 instance
@rhysdg rhysdg added bug Something isn't working enhancement New feature or request labels Aug 19, 2022
@rhysdg rhysdg self-assigned this Aug 19, 2022
@rhysdg
Copy link
Owner Author

rhysdg commented Sep 13, 2022 •
edited
Loading

  • Linking the results of CI in with this too. Despite tetsing passing its obvious that it fails at the Inference step. This fix should resolve this.
  • Despite suggesstion in ONNX's documentation regarding a CPU fallback fix it looks like we're going to have to go for a simple try except.

@rhysdg
Copy link
Owner Author

rhysdg commented Sep 13, 2022

-Fixed with the following. CI stills flags a Cuda Exception given the CPU only runner but falls back to a CPU execution provider in both testing an on installation of robonnx package.

  • See #5299 for discussion with regards to implementation within the InferenceSession class

@rhysdg rhysdg closed this as completed Sep 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rhysdg rhysdg

Labels
bug Something isn't working enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@rhysdg