Skip to content
This repository has been archived by the owner on Oct 29, 2018. It is now read-only.

Pvayladev 691 hotfix execlisting package list #1

Merged

Conversation

skallio
Copy link
Contributor

@skallio skallio commented Feb 10, 2017

No description provided.

Copy link
Contributor

@jansu76 jansu76 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine to me

Copy link
Contributor

@VitaliStupin VitaliStupin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

build process ended with:

parsechangelog/debian: warning: debian/changelog(l3): badly formatted heading line
LINE: * PVAYLADEV-691: Hotfix for ExecListingSensor init. (Fixes package listing information, etc)
parsechangelog/debian: warning: debian/changelog(l5): badly formatted heading line
LINE: -- Sami Kallio sami.kallio@gofore.com Fri, 10 FebJan 2017 14:05:11 +0200
parsechangelog/debian: warning: debian/changelog(l8): found start of entry where expected start of change data
LINE: xroad (6.9.2) trusty; urgency=low
parsechangelog/debian: warning: debian/changelog(l8): found eof where expected start of change data
dpkg-buildpackage: error: unable to determine source changed by
dpkg-buildpackage: source package xroad
dpkg-buildpackage: source version 6.9.3
dpkg-buildpackage: source distribution trusty Build step 'Execute shell' marked build as failure

@VitaliStupin
Copy link
Contributor

VitaliStupin commented Feb 10, 2017

You should add missing whitespaces to the:
https://github.com/vrk-kpa/X-Road/blob/PVAYLADEV-691-hotfix-execlisting-package-list/xtee6/packages/xroad/debian/changelog

This is the same problem as that:
vrk-kpa/xroad-joint-development#107

But this time "-- Sami Kallio..." line was also missing whitespaces which resulted in error instead of warning.


* Version bump

-- Sami Kallio <sami.kallio@gofore.com> Fri, 10 FebJan 2017 14:05:11 +0200
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LINE: -- Sami Kallio sami.kallio@gofore.com Fri, 10 FebJan 2017 14:05:11 +0200
parsechangelog/debian: warning: xroad-jetty9/debian/changelog(l5): couldn't parse date Fri, 10 FebJan 2017 14:05:11 +0200

@@ -2,7 +2,7 @@

set -e

./compile_code.sh "$@"
#./compile_code.sh "$@"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not feel right. We need to compile the code before packaging.

@@ -1,3 +1,9 @@
xroad-jetty9 (6.9.3) trusty; urgency=low

* Version bump
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Packaging still warns about this line.

parsechangelog/debian: warning: debian/changelog(l3): unrecognized line
LINE: * Version bump
parsechangelog/debian: warning: debian/changelog(l5): found trailer where expected start of change data
LINE: -- Sami Kallio sami.kallio@gofore.com Mon, 13 Feb 2017 10:24:15 +0200

Needs one additional space, I think.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants