Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linting and Style Rules #35

Closed
albsch opened this issue Feb 7, 2020 · 0 comments · Fixed by #46
Closed

Linting and Style Rules #35

albsch opened this issue Feb 7, 2020 · 0 comments · Fixed by #46
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@albsch
Copy link
Member

albsch commented Feb 7, 2020

Decide on style rules for linting and fix them.
@albsch albsch added enhancement New feature or request good first issue Good for newcomers labels Feb 7, 2020
albsch pushed a commit that referenced this issue Feb 7, 2020
Added lint command and lint to pipeline (#35)
c55b96e
albsch pushed a commit that referenced this issue Feb 15, 2020
Added lint command and lint to pipeline (#35)
7d5ea3f
albsch pushed a commit that referenced this issue Feb 15, 2020
Added lint command and lint to pipeline (#35)
bbee20f
albsch pushed a commit that referenced this issue Feb 18, 2020
Added lint command and lint to pipeline (#35)
2b2f5e7
WoelkiM pushed a commit to WoelkiM/riak_core_lite that referenced this issue Mar 2, 2020
riak-core-lite#35
e76bcab 
Code adaptations to the code guidelines defined in elvis.config. These contain the following elvis_style definitions:

done:
  line_length<= 100 chars,
  no_tabs,
  no_trailing_whitespace
  macro_names,
  macro_module_names,
  operator_spaces: right:"," "++" "--" left: "++" "--"
  used_ignored_variable,
  no_behavior_info,
  module_naming_convention regex => "^[a-z]([a-z0-9]*_?)*(_SUITE)?$"
  function_naming_convention regex => "^[a-z]([a-z0-9]*_?)*$"
  state_record_and_type,
  no_spec_with_records

todo:
  god_modules limit => 40  Problems in riak_core(101 functions) and riak_core_util(63 functions) these contain too many functions.

optional:
  no_if_expression,
  dont_repeat_yourself #{min_complexity => 10}
  no_debug_call
WoelkiM pushed a commit to WoelkiM/riak_core_lite that referenced this issue Mar 3, 2020
riak-core-lite#35 Correction of the spelling typo.
9b4143d
WoelkiM pushed a commit to WoelkiM/riak_core_lite that referenced this issue Mar 9, 2020
riak-core-lite#35 remove TODO after inspection from my side.
956f680
albsch pushed a commit to WoelkiM/riak_core_lite that referenced this issue Mar 10, 2020
Added lint command and lint to pipeline (riak-core-lite#35)
efdff2a
albsch pushed a commit to WoelkiM/riak_core_lite that referenced this issue Mar 10, 2020
riak-core-lite#35
f7f19de 
Code adaptations to the code guidelines defined in elvis.config. These contain the following elvis_style definitions:

done:
  line_length<= 100 chars,
  no_tabs,
  no_trailing_whitespace
  macro_names,
  macro_module_names,
  operator_spaces: right:"," "++" "--" left: "++" "--"
  used_ignored_variable,
  no_behavior_info,
  module_naming_convention regex => "^[a-z]([a-z0-9]*_?)*(_SUITE)?$"
  function_naming_convention regex => "^[a-z]([a-z0-9]*_?)*$"
  state_record_and_type,
  no_spec_with_records

todo:
  god_modules limit => 40  Problems in riak_core(101 functions) and riak_core_util(63 functions) these contain too many functions.

optional:
  no_if_expression,
  dont_repeat_yourself #{min_complexity => 10}
  no_debug_call
albsch pushed a commit to WoelkiM/riak_core_lite that referenced this issue Mar 10, 2020
riak-core-lite#35 Correction of the spelling typo.
8518005
albsch pushed a commit to WoelkiM/riak_core_lite that referenced this issue Mar 10, 2020
riak-core-lite#35 remove TODO after inspection from my side.
cefe8a4
albsch pushed a commit that referenced this issue Mar 10, 2020
@WoelkiM
#35 (#45)
ae04c5a 
Added linting.
albsch pushed a commit that referenced this issue Mar 10, 2020
Added lint command and lint to pipeline (#35)
f636209
albsch pushed a commit that referenced this issue Mar 10, 2020
@WoelkiM
#35 (#45)
d540202 
Added linting.
@albsch albsch mentioned this issue Mar 10, 2020
Merged
albsch pushed a commit that referenced this issue Mar 10, 2020
@albsch
Added lint command and lint to pipeline (#35)
735956d
albsch pushed a commit that referenced this issue Mar 10, 2020
@WoelkiM @albsch
#35 (#45)
1b23a2e 
Added linting.
albsch pushed a commit that referenced this issue Jul 13, 2021
Added lint command and lint to pipeline (#35)
92a5976
albsch pushed a commit that referenced this issue Jul 13, 2021
@WoelkiM
#35 (#45)
33adebf 
Added linting.
albsch pushed a commit that referenced this issue Jul 13, 2021
@WoelkiM
#35 (#45)
6a7a637 
Added linting.
albsch pushed a commit that referenced this issue Jul 13, 2021
Added lint command and lint to pipeline (#35)
a0902d6
albsch pushed a commit that referenced this issue Jul 13, 2021
@WoelkiM
#35 (#45)
76486a8 
Added linting.
albsch pushed a commit that referenced this issue Jul 13, 2021
Added lint command and lint to pipeline (#35)
f8edc41
albsch pushed a commit that referenced this issue Jul 13, 2021
@WoelkiM
#35 (#45)
f973047 
Added linting.
albsch pushed a commit that referenced this issue Jul 13, 2021
Added lint command and lint to pipeline (#35)
cb61c98
albsch pushed a commit that referenced this issue Jul 13, 2021
@WoelkiM
#35 (#45)
91f7833 
Added linting.
albsch pushed a commit that referenced this issue Jul 13, 2021
Added lint command and lint to pipeline (#35)
d530287
albsch pushed a commit that referenced this issue Jul 13, 2021
@WoelkiM
#35 (#45)
226c293 
Added linting.
albsch added a commit that referenced this issue Jul 13, 2021
@albsch @WoelkiM
@RoadRunnr @peterzeller
V0.10.1 (#96)
3f836ae 
* riak_core_vnode_worker_pool to gen_statem (#19)
* Added E22 to pipeline
* Fixed Readme and descriptions to fit riak_core_lite
* Included outside dependencies again
 * Fixed deprecation warnings in those dependencies
* Added xref to pipeline
* Added badge that tracks hex.pm version
* Added coverage support
* Removed unused test dependencies (goldrush, mustache). Added missing meck dependency to tests
* Made edoc work again. Replaced macros with direct calls. Added edoc to pipeline
* Replaced mochiglobal with persistent_term (#43)
* Added lint command and lint to pipeline (#35)
* #35 (#45)
* fix riak_core_status:ringready/0 (#52) Added test case.
* Formatter (#53)
* Added default rebar3_format
* Changed to otp_formatter, fixed one issue in code by refactoring
* Adjusted pipeline
* Unused modules (#58)
* Bloom filter removed
* Removed stats util modules
* Removed one eqc files.
* property based testing (#61)
* update travis
* adjust number of test executions
* update coverage + bug fixing in riak_core_claim
* 20 replaced riak_core_gen_server with gen_server (#63)
* Erlang 23 Pipeline (#64)
* Format with E23, increased line length by 20
* Added E23 to pipeline
* PR basho#959 upstream (#65)
* Added unit test case which enforces the deadlock prior the fix
* V0.10.1 release
* #70
* Moved proper to project_plugins (#72)
* Finish removing bucket properties and buckets (#75)

Co-authored-by: Wölki <55596379+WoelkiM@users.noreply.github.com>
Co-authored-by: Andreas Schultz <andreas.schultz@travelping.com>
Co-authored-by: woelki <m_woelki14@cs.uni-kl.de>
Co-authored-by: Peter Zeller <p_zeller@cs.uni-kl.de>
albsch added a commit that referenced this issue Mar 21, 2022
@albsch @RoadRunnr @peterzeller
V0.10.1 (#96)
da612b5 
* riak_core_vnode_worker_pool to gen_statem (#19)
* Added E22 to pipeline
* Fixed Readme and descriptions to fit riak_core_lite
* Included outside dependencies again
 * Fixed deprecation warnings in those dependencies
* Added xref to pipeline
* Added badge that tracks hex.pm version
* Added coverage support
* Removed unused test dependencies (goldrush, mustache). Added missing meck dependency to tests
* Made edoc work again. Replaced macros with direct calls. Added edoc to pipeline
* Replaced mochiglobal with persistent_term (#43)
* Added lint command and lint to pipeline (#35)
* #35 (#45)
* fix riak_core_status:ringready/0 (#52) Added test case.
* Formatter (#53)
* Added default rebar3_format
* Changed to otp_formatter, fixed one issue in code by refactoring
* Adjusted pipeline
* Unused modules (#58)
* Bloom filter removed
* Removed stats util modules
* Removed one eqc files.
* property based testing (#61)
* update travis
* adjust number of test executions
* update coverage + bug fixing in riak_core_claim
* 20 replaced riak_core_gen_server with gen_server (#63)
* Erlang 23 Pipeline (#64)
* Format with E23, increased line length by 20
* Added E23 to pipeline
* PR basho#959 upstream (#65)
* Added unit test case which enforces the deadlock prior the fix
* V0.10.1 release
* #70
* Moved proper to project_plugins (#72)
* Finish removing bucket properties and buckets (#75)

Co-authored-by: Andreas Schultz <andreas.schultz@travelping.com>
Co-authored-by: woelki <m_woelki14@cs.uni-kl.de>
Co-authored-by: Peter Zeller <p_zeller@cs.uni-kl.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

35 linting and style rules riak-core-lite/riak_core_lite
1 participant
@albsch