-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#35 #45
#35 #45
Conversation
…oins Make staged joins mandatory
…meck dependency to tests
I don't understand why build Edit: It didn't compile for me, checked out the wrong branch. |
src/gen_fsm_compat.erl
Outdated
Header = gen:format_status_header("Status for state machine", | ||
Name), | ||
[PDict, SysState, Parent, Debug, [Name, StateName, StateData, | ||
od, _Time, _HibernateAfterTimeout]] = |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The M is missing, of course Mod
will be unbound. Please check every file again for this kind of error.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm sorry. When I built it, everything worked.
I will check all files again, that such a mistake no longer occurs.
@albsch I've checked everything again and from my side everything should fit. |
Code adaptations to the code guidelines defined in elvis.config. These contain the following elvis_style definitions: done: line_length<= 100 chars, no_tabs, no_trailing_whitespace macro_names, macro_module_names, operator_spaces: right:"," "++" "--" left: "++" "--" used_ignored_variable, no_behavior_info, module_naming_convention regex => "^[a-z]([a-z0-9]*_?)*(_SUITE)?$" function_naming_convention regex => "^[a-z]([a-z0-9]*_?)*$" state_record_and_type, no_spec_with_records todo: god_modules limit => 40 Problems in riak_core(101 functions) and riak_core_util(63 functions) these contain too many functions. optional: no_if_expression, dont_repeat_yourself #{min_complexity => 10} no_debug_call
956f680
to
903b21f
Compare
Looks good, rebased to master and merging after PR is green. |
* riak_core_vnode_worker_pool to gen_statem (#19) * Added E22 to pipeline * Fixed Readme and descriptions to fit riak_core_lite * Included outside dependencies again * Fixed deprecation warnings in those dependencies * Added xref to pipeline * Added badge that tracks hex.pm version * Added coverage support * Removed unused test dependencies (goldrush, mustache). Added missing meck dependency to tests * Made edoc work again. Replaced macros with direct calls. Added edoc to pipeline * Replaced mochiglobal with persistent_term (#43) * Added lint command and lint to pipeline (#35) * #35 (#45) * fix riak_core_status:ringready/0 (#52) Added test case. * Formatter (#53) * Added default rebar3_format * Changed to otp_formatter, fixed one issue in code by refactoring * Adjusted pipeline * Unused modules (#58) * Bloom filter removed * Removed stats util modules * Removed one eqc files. * property based testing (#61) * update travis * adjust number of test executions * update coverage + bug fixing in riak_core_claim * 20 replaced riak_core_gen_server with gen_server (#63) * Erlang 23 Pipeline (#64) * Format with E23, increased line length by 20 * Added E23 to pipeline * PR basho#959 upstream (#65) * Added unit test case which enforces the deadlock prior the fix * V0.10.1 release * #70 * Moved proper to project_plugins (#72) * Finish removing bucket properties and buckets (#75) Co-authored-by: Wölki <55596379+WoelkiM@users.noreply.github.com> Co-authored-by: Andreas Schultz <andreas.schultz@travelping.com> Co-authored-by: woelki <m_woelki14@cs.uni-kl.de> Co-authored-by: Peter Zeller <p_zeller@cs.uni-kl.de>
* riak_core_vnode_worker_pool to gen_statem (#19) * Added E22 to pipeline * Fixed Readme and descriptions to fit riak_core_lite * Included outside dependencies again * Fixed deprecation warnings in those dependencies * Added xref to pipeline * Added badge that tracks hex.pm version * Added coverage support * Removed unused test dependencies (goldrush, mustache). Added missing meck dependency to tests * Made edoc work again. Replaced macros with direct calls. Added edoc to pipeline * Replaced mochiglobal with persistent_term (#43) * Added lint command and lint to pipeline (#35) * #35 (#45) * fix riak_core_status:ringready/0 (#52) Added test case. * Formatter (#53) * Added default rebar3_format * Changed to otp_formatter, fixed one issue in code by refactoring * Adjusted pipeline * Unused modules (#58) * Bloom filter removed * Removed stats util modules * Removed one eqc files. * property based testing (#61) * update travis * adjust number of test executions * update coverage + bug fixing in riak_core_claim * 20 replaced riak_core_gen_server with gen_server (#63) * Erlang 23 Pipeline (#64) * Format with E23, increased line length by 20 * Added E23 to pipeline * PR basho#959 upstream (#65) * Added unit test case which enforces the deadlock prior the fix * V0.10.1 release * #70 * Moved proper to project_plugins (#72) * Finish removing bucket properties and buckets (#75) Co-authored-by: Andreas Schultz <andreas.schultz@travelping.com> Co-authored-by: woelki <m_woelki14@cs.uni-kl.de> Co-authored-by: Peter Zeller <p_zeller@cs.uni-kl.de>
Code adaptations to the code guidelines defined in elvis.config. These contain the following elvis_style definitions:
done:
line_length<= 100 chars,
no_tabs,
no_trailing_whitespace
macro_names,
macro_module_names,
operator_spaces: right:"," "++" "--" left: "++" "--"
used_ignored_variable,
no_behavior_info,
module_naming_convention regex => "^a-z(_SUITE)?$"
function_naming_convention regex => "^a-z$"
state_record_and_type,
no_spec_with_records
todo:
god_modules limit => 40 Problems in riak_core(101 functions) and riak_core_util(63 functions) these contain too many functions.
optional:
no_if_expression,
dont_repeat_yourself #{min_complexity => 10}
no_debug_call