Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replaced mochiglobal with persistent_term #43

Merged
merged 2 commits into from
Feb 18, 2020
Merged

Conversation

albsch
Copy link
Member

@albsch albsch commented Feb 17, 2020

Replace mochiglobal with Erlang's persistent_term.

@albsch albsch added enhancement New feature or request reduce Issues concerning reduction of the code base labels Feb 17, 2020
Copy link
Member

@marianoguerra marianoguerra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

%%
%% However, updating a `mochiglobal' value is very slow, and becomes slower
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

maybe just link here?

http://erlang.org/doc/man/persistent_term.html#description the first paragraph could be copied here to have something before following the link, but removing the previous mochiglobal comments which seem to sort of apply but not sure all apply

@albsch albsch merged commit dec5453 into master Feb 18, 2020
@albsch albsch deleted the replace-mochiglobal branch February 18, 2020 11:22
@WoelkiM WoelkiM mentioned this pull request Apr 7, 2021
2 tasks
albsch added a commit that referenced this pull request Jul 13, 2021
* Replaced mochiglobal with persistent_term
* Added link to erlang persistent_term
albsch added a commit that referenced this pull request Jul 13, 2021
* Replaced mochiglobal with persistent_term
* Added link to erlang persistent_term
albsch added a commit that referenced this pull request Jul 13, 2021
* Replaced mochiglobal with persistent_term
* Added link to erlang persistent_term
albsch added a commit that referenced this pull request Jul 13, 2021
* Replaced mochiglobal with persistent_term
* Added link to erlang persistent_term
albsch added a commit that referenced this pull request Jul 13, 2021
* Replaced mochiglobal with persistent_term
* Added link to erlang persistent_term
albsch added a commit that referenced this pull request Jul 13, 2021
* Replaced mochiglobal with persistent_term
* Added link to erlang persistent_term
albsch added a commit that referenced this pull request Jul 13, 2021
* riak_core_vnode_worker_pool to gen_statem (#19)
* Added E22 to pipeline
* Fixed Readme and descriptions to fit riak_core_lite
* Included outside dependencies again
 * Fixed deprecation warnings in those dependencies
* Added xref to pipeline
* Added badge that tracks hex.pm version
* Added coverage support
* Removed unused test dependencies (goldrush, mustache). Added missing meck dependency to tests
* Made edoc work again. Replaced macros with direct calls. Added edoc to pipeline
* Replaced mochiglobal with persistent_term (#43)
* Added lint command and lint to pipeline (#35)
* #35 (#45)
* fix riak_core_status:ringready/0 (#52) Added test case.
* Formatter (#53)
* Added default rebar3_format
* Changed to otp_formatter, fixed one issue in code by refactoring
* Adjusted pipeline
* Unused modules (#58)
* Bloom filter removed
* Removed stats util modules
* Removed one eqc files.
* property based testing (#61)
* update travis
* adjust number of test executions
* update coverage + bug fixing in riak_core_claim
* 20 replaced riak_core_gen_server with gen_server (#63)
* Erlang 23 Pipeline (#64)
* Format with E23, increased line length by 20
* Added E23 to pipeline
* PR basho#959 upstream (#65)
* Added unit test case which enforces the deadlock prior the fix
* V0.10.1 release
* #70
* Moved proper to project_plugins (#72)
* Finish removing bucket properties and buckets (#75)

Co-authored-by: Wölki <55596379+WoelkiM@users.noreply.github.com>
Co-authored-by: Andreas Schultz <andreas.schultz@travelping.com>
Co-authored-by: woelki <m_woelki14@cs.uni-kl.de>
Co-authored-by: Peter Zeller <p_zeller@cs.uni-kl.de>
albsch added a commit that referenced this pull request Mar 21, 2022
* riak_core_vnode_worker_pool to gen_statem (#19)
* Added E22 to pipeline
* Fixed Readme and descriptions to fit riak_core_lite
* Included outside dependencies again
 * Fixed deprecation warnings in those dependencies
* Added xref to pipeline
* Added badge that tracks hex.pm version
* Added coverage support
* Removed unused test dependencies (goldrush, mustache). Added missing meck dependency to tests
* Made edoc work again. Replaced macros with direct calls. Added edoc to pipeline
* Replaced mochiglobal with persistent_term (#43)
* Added lint command and lint to pipeline (#35)
* #35 (#45)
* fix riak_core_status:ringready/0 (#52) Added test case.
* Formatter (#53)
* Added default rebar3_format
* Changed to otp_formatter, fixed one issue in code by refactoring
* Adjusted pipeline
* Unused modules (#58)
* Bloom filter removed
* Removed stats util modules
* Removed one eqc files.
* property based testing (#61)
* update travis
* adjust number of test executions
* update coverage + bug fixing in riak_core_claim
* 20 replaced riak_core_gen_server with gen_server (#63)
* Erlang 23 Pipeline (#64)
* Format with E23, increased line length by 20
* Added E23 to pipeline
* PR basho#959 upstream (#65)
* Added unit test case which enforces the deadlock prior the fix
* V0.10.1 release
* #70
* Moved proper to project_plugins (#72)
* Finish removing bucket properties and buckets (#75)

Co-authored-by: Andreas Schultz <andreas.schultz@travelping.com>
Co-authored-by: woelki <m_woelki14@cs.uni-kl.de>
Co-authored-by: Peter Zeller <p_zeller@cs.uni-kl.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request reduce Issues concerning reduction of the code base
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants