Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

osrmRoute argument order #105

Closed
wcjochem opened this issue Aug 24, 2022 · 1 comment
Closed

osrmRoute argument order #105

wcjochem opened this issue Aug 24, 2022 · 1 comment

Comments

@wcjochem
Copy link

When I was testing this package, I noticed that the order of the arguments for osrmRoute is different from osrmTable. Is there a reason for this?

This seems like a minor design question, but I was confused that there were 3 potential inputs. Could you consider having just src and dst as inputs, with src always required and dst be optional (or, if not supplied set it to be src)

For example:

osrmTable <- function(src, dst = src, exclude = NULL ...)
{
	# check inputs
	if(missing(src){ stop() }
}
@rCarto
Copy link
Member

rCarto commented Sep 9, 2022

fixed in faf8b31
osrmRoute() and osrmTable() arguments are now aligned.
I'll keep the loc arg for backward compatibility and ease of use.

@rCarto rCarto closed this as completed Sep 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants